pull request template

pull_request_template.md

Description

Please include a summary of the change, feature or which issue is fixed.

Type of change

• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Area of change

• Frontend
• Backend
• DB
• Monitoring

General checklist:

• Code follows the style guidelines of this project
• I ran helm lint/terraform fmt before commit
• I have performed a self-review of code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation where needed
• These changes generate no new warnings
• I have checked the code and corrected any misspellings
• I have updated master and merged to my branch before submitting pull request
• This pull request generate no conflicts with master branch
• I requested code review from other team members

Frontend checklist:

• I followed guidelines for HTML/LIQUID, SCSS, JAVASCRIPT from readme
• My Javascript generate no new console errors
• I tested my code cross browsers
• My slice is pixel perfect for both desktop and mobile according to design
• I conducted basic QA to assure all features are working
• I tested responsive for mobile and tablet resolutions

Backend checklist:

• I tested admin by manually adding content from zero
• I followed guidelines for naming admin fields
• I created easy to use admin experience which is self-explanatory
• I added description to admin fields in hard-to-understand areas
• I followed guidelines for naming php/liquid variables
• I conducted basic QA to assure all features are working