Skip to content

Instantly share code, notes, and snippets.

@passy
Created October 25, 2017 09:02
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save passy/d62afb4261f7ffd93036acd71c27217f to your computer and use it in GitHub Desktop.
Save passy/d62afb4261f7ffd93036acd71c27217f to your computer and use it in GitHub Desktop.
commit 9957e3b5fae1cd14a7173811253dc11769729869
Author: Pascal Hartig <phartig@rdrei.net>
Date: Wed Oct 25 10:00:42 2017 +0100
Remove now redundant @JvmStatic
diff --git a/sample-kotlin/src/main/java/com/fblitho/lithoktsample/lithography/components/FavouriteButtonSpec.kt b/sample-kotlin/src/main/java/com/fblitho/lithoktsample/lithography/components/FavouriteButtonSpec.kt
index 7a1178d20..9822060da 100755
--- a/sample-kotlin/src/main/java/com/fblitho/lithoktsample/lithography/components/FavouriteButtonSpec.kt
+++ b/sample-kotlin/src/main/java/com/fblitho/lithoktsample/lithography/components/FavouriteButtonSpec.kt
@@ -41,11 +41,9 @@ object FavouriteButtonSpec {
.clickHandler(FavouriteButton.onClick(c))
.build()
- @JvmStatic
@OnUpdateState
fun toggleFavourited(favourited: StateValue<Boolean>) = favourited.set(!favourited.get())
- @JvmStatic
@OnEvent(ClickEvent::class)
- fun onClick(c: ComponentContext, @FromEvent view: View) = FavouriteButton.toggleFavourited(c)
+ fun onClick(c: ComponentContext, @FromEvent view: View) = FavouriteButton.toggleFavourited(c) as Unit
}
diff --git a/sample-kotlin/src/main/java/com/fblitho/lithoktsample/lithography/components/StoryCardComponentSpec.kt b/sample-kotlin/src/main/java/com/fblitho/lithoktsample/lithography/components/StoryCardComponentSpec.kt
index da8fe3856..8c2ce133c 100644
--- a/sample-kotlin/src/main/java/com/fblitho/lithoktsample/lithography/components/StoryCardComponentSpec.kt
+++ b/sample-kotlin/src/main/java/com/fblitho/lithoktsample/lithography/components/StoryCardComponentSpec.kt
@@ -52,7 +52,6 @@ object StoryCardComponentSpec {
internal val CARD_INSET = 12
internal val CARD_INTERNAL_PADDING = 7
- @JvmStatic
@OnCreateLayout
internal fun onCreateLayout(
c: ComponentContext, @Prop header: Component<*>, @Prop content: String, @State saved: Boolean): ComponentLayout {
@@ -86,7 +85,6 @@ object StoryCardComponentSpec {
.build()
}
- @JvmStatic
@OnCreateInitialState
fun onCreateInitialState(
c: ComponentContext,
@@ -94,13 +92,11 @@ object StoryCardComponentSpec {
saved.set(false)
}
- @JvmStatic
@OnUpdateState
fun onToggleSavedState(saved: StateValue<Boolean>) {
saved.set(!saved.get())
}
- @JvmStatic
@OnEvent(ClickEvent::class)
fun onClickSave(c: ComponentContext) {
StoryCardComponent.onToggleSavedState(c)
diff --git a/sample-kotlin/src/main/java/com/fblitho/lithoktsample/lithography/sections/DecadeSectionSpec.kt b/sample-kotlin/src/main/java/com/fblitho/lithoktsample/lithography/sections/DecadeSectionSpec.kt
index 503f230b2..557bdff0e 100644
--- a/sample-kotlin/src/main/java/com/fblitho/lithoktsample/lithography/sections/DecadeSectionSpec.kt
+++ b/sample-kotlin/src/main/java/com/fblitho/lithoktsample/lithography/sections/DecadeSectionSpec.kt
@@ -50,7 +50,6 @@ object DecadeSectionSpec {
.build()
- @JvmStatic
@OnEvent(RenderEvent::class)
fun render(
c: SectionContext,
@@ -59,7 +58,6 @@ object DecadeSectionSpec {
.component(FeedItemCard.create(c).artist(model).build())
.build()
- @JvmStatic
@OnEvent(OnCheckIsSameItemEvent::class)
fun isSameItem(
c: SectionContext,
diff --git a/sample-kotlin/src/main/java/com/fblitho/lithoktsample/lithography/sections/ImagesSectionSpec.kt b/sample-kotlin/src/main/java/com/fblitho/lithoktsample/lithography/sections/ImagesSectionSpec.kt
index 3b3acf159..8cd423d1e 100644
--- a/sample-kotlin/src/main/java/com/fblitho/lithoktsample/lithography/sections/ImagesSectionSpec.kt
+++ b/sample-kotlin/src/main/java/com/fblitho/lithoktsample/lithography/sections/ImagesSectionSpec.kt
@@ -38,7 +38,6 @@ object ImagesSectionSpec {
.build()
- @JvmStatic
@OnEvent(RenderEvent::class)
fun onRender(
c: SectionContext, @FromEvent model: String): RenderInfo =
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment