Skip to content

Instantly share code, notes, and snippets.

@patrickclery
Last active April 30, 2020 13:34
Show Gist options
  • Save patrickclery/76607982d6ee15b51d08b892c96d2f93 to your computer and use it in GitHub Desktop.
Save patrickclery/76607982d6ee15b51d08b892c96d2f93 to your computer and use it in GitHub Desktop.
PR Checklist
### PR Checklist
- [ ] **Review code coverage report (CodeCov)**
* Has coverage gone up or down with this feature?
* Do we need to add or update tests?
- [ ] **Merge from dev to feature branch** and resolve any merge conflicts
- [ ] **Review CodeClimate** report and improve where possible
- [ ] **Documentation**
* Is there any documentation that should be added back to the ticket (deployment notes for example) or the wiki for a more detailed explanation of the feature or fixes?
* Is there any existing documentation relating to this fix/enhancement/feature that needs to be updated (usage, behavior, tech requirements, configuration)?
* Is there any new documentation that can be added to the benefit of others?
> none needed, mostly reusing existing ideas
- [ ] **Demo/feedback pass** of feature/fix
* Show others (let them know of new features)
* Get feedback from PM - can be a quick walkthrough (this might be iterative process)
- [ ] **Review Files Changed** tab
* Variable and method naming consistency?
* Commented out code?
* Debug/puts/logging blocks?
* Gems/modules/code changes that are not needed?
- [ ] **Run relevant tests** to ensure there are no side effects from new or modified code
### GitHub PR Page
- [ ] CircleCI tests
### THINK: Were any of these RELATED AREAS be affected?
_(If yes, then check off and comment)_
- [ ] .env.example
- [ ] config
- [ ] application.rb
- [ ] environments
- [ ] app
- [ ] forms
- [ ] controllers
- [ ] queries
- [ ] spec
- [ ] forms
- [ ] factories
- [ ] fixtures
- [ ] features
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment