Skip to content

Instantly share code, notes, and snippets.

View paulovitorbal's full-sized avatar

Paulo Vitor Bettini de Paiva Lima paulovitorbal

  • Brasilia, Brazil
View GitHub Profile
@paulovitorbal
paulovitorbal / code-review-checklist.md
Last active October 30, 2018 16:22 — forked from nerandell/code-review-checklist.md
PHP Code Review Guidelines

Make sure these boxes are checked before submitting/approving the PR

General

  • The code works
  • The code is easy to understand
  • Names are simple and if possible short
  • Names are spelt correctly
  • Names contain units where applicable
  • There are no usages of magic numbers
  • No hard coded constants that could possibly change in the future