Created
May 31, 2016 16:19
-
-
Save pelwell/e42758ee8cbe2ca864c6eb0452df54f6 to your computer and use it in GitHub Desktop.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| WARNING: line over 80 characters | |
| #37: FILE: drivers/net/wireless/realtek/rtl8192cu/core/rtw_ioctl_set.c:538: | |
| +u8 rtw_set_802_11_connect(_adapter* padapter, const u8 *bssid, NDIS_802_11_SSID *ssid) | |
| ERROR: "foo* bar" should be "foo *bar" | |
| #37: FILE: drivers/net/wireless/realtek/rtl8192cu/core/rtw_ioctl_set.c:538: | |
| +u8 rtw_set_802_11_connect(_adapter* padapter, const u8 *bssid, NDIS_802_11_SSID *ssid) | |
| WARNING: line over 80 characters | |
| #76: FILE: drivers/net/wireless/realtek/rtl8192cu/include/autoconf.h:36: | |
| + #define RTW_USE_CFG80211_STA_EVENT /* Indecate new sta asoc through cfg80211_new_sta */ | |
| ERROR: do not use C99 // comments | |
| #77: FILE: drivers/net/wireless/realtek/rtl8192cu/include/autoconf.h:37: | |
| + //#define CONFIG_CFG80211_FORCE_COMPATIBLE_2_6_37_UNDER | |
| ERROR: do not use C99 // comments | |
| #86: FILE: drivers/net/wireless/realtek/rtl8192cu/include/autoconf.h:327: | |
| +//#define DBG_CONFIG_ERROR_DETECT | |
| WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged | |
| #99: FILE: drivers/net/wireless/realtek/rtl8192cu/include/ioctl_cfg80211.h:152: | |
| +#elif (LINUX_VERSION_CODE < KERNEL_VERSION(3,12,0)) | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #99: FILE: drivers/net/wireless/realtek/rtl8192cu/include/ioctl_cfg80211.h:152: | |
| +#elif (LINUX_VERSION_CODE < KERNEL_VERSION(3,12,0)) | |
| ^ | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #99: FILE: drivers/net/wireless/realtek/rtl8192cu/include/ioctl_cfg80211.h:152: | |
| +#elif (LINUX_VERSION_CODE < KERNEL_VERSION(3,12,0)) | |
| ^ | |
| WARNING: Comparisons should place the constant on the right side of the test | |
| #99: FILE: drivers/net/wireless/realtek/rtl8192cu/include/ioctl_cfg80211.h:152: | |
| +#elif (LINUX_VERSION_CODE < KERNEL_VERSION(3,12,0)) | |
| WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged | |
| #101: FILE: drivers/net/wireless/realtek/rtl8192cu/include/ioctl_cfg80211.h:154: | |
| +#elif (LINUX_VERSION_CODE < KERNEL_VERSION(3,18,0)) | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #101: FILE: drivers/net/wireless/realtek/rtl8192cu/include/ioctl_cfg80211.h:154: | |
| +#elif (LINUX_VERSION_CODE < KERNEL_VERSION(3,18,0)) | |
| ^ | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #101: FILE: drivers/net/wireless/realtek/rtl8192cu/include/ioctl_cfg80211.h:154: | |
| +#elif (LINUX_VERSION_CODE < KERNEL_VERSION(3,18,0)) | |
| ^ | |
| WARNING: Comparisons should place the constant on the right side of the test | |
| #101: FILE: drivers/net/wireless/realtek/rtl8192cu/include/ioctl_cfg80211.h:154: | |
| +#elif (LINUX_VERSION_CODE < KERNEL_VERSION(3,18,0)) | |
| ERROR: do not use C99 // comments | |
| #102: FILE: drivers/net/wireless/realtek/rtl8192cu/include/ioctl_cfg80211.h:155: | |
| +// 3.12 added a flags argument which is just set to zero | |
| WARNING: line over 80 characters | |
| #103: FILE: drivers/net/wireless/realtek/rtl8192cu/include/ioctl_cfg80211.h:156: | |
| +#define rtw_cfg80211_rx_mgmt(adapter, freq, sig_dbm, buf, len, gfp) cfg80211_rx_mgmt((adapter)->rtw_wdev, freq, sig_dbm, buf, len, 0, gfp) | |
| WARNING: line over 80 characters | |
| #105: FILE: drivers/net/wireless/realtek/rtl8192cu/include/ioctl_cfg80211.h:158: | |
| +#define rtw_cfg80211_rx_mgmt(adapter, freq, sig_dbm, buf, len, gfp) cfg80211_rx_mgmt((adapter)->rtw_wdev, freq, sig_dbm, buf, len, 0) | |
| ERROR: "foo* bar" should be "foo *bar" | |
| #119: FILE: drivers/net/wireless/realtek/rtl8192cu/include/osdep_service.h:1398: | |
| +extern void _rtw_memcpy(void* dec, const void* sour, u32 sz); | |
| ERROR: "foo* bar" should be "foo *bar" | |
| #119: FILE: drivers/net/wireless/realtek/rtl8192cu/include/osdep_service.h:1398: | |
| +extern void _rtw_memcpy(void* dec, const void* sour, u32 sz); | |
| CHECK: extern prototypes should be avoided in .h files | |
| #119: FILE: drivers/net/wireless/realtek/rtl8192cu/include/osdep_service.h:1398: | |
| +extern void _rtw_memcpy(void* dec, const void* sour, u32 sz); | |
| CHECK: extern prototypes should be avoided in .h files | |
| #120: FILE: drivers/net/wireless/realtek/rtl8192cu/include/osdep_service.h:1399: | |
| +extern int _rtw_memcmp(const void *dst, const void *src, u32 sz); | |
| WARNING: line over 80 characters | |
| #133: FILE: drivers/net/wireless/realtek/rtl8192cu/include/rtw_ioctl_set.h:66: | |
| +u8 rtw_set_802_11_connect(_adapter* padapter, const u8 *bssid, NDIS_802_11_SSID *ssid); | |
| ERROR: "foo* bar" should be "foo *bar" | |
| #133: FILE: drivers/net/wireless/realtek/rtl8192cu/include/rtw_ioctl_set.h:66: | |
| +u8 rtw_set_802_11_connect(_adapter* padapter, const u8 *bssid, NDIS_802_11_SSID *ssid); | |
| WARNING: storage class should be at the beginning of the declaration | |
| #150: FILE: drivers/net/wireless/realtek/rtl8192cu/include/sta_info.h:398: | |
| +__inline static u32 wifi_mac_hash(const u8 *mac) | |
| ERROR: inline keyword should sit between storage class and type | |
| #150: FILE: drivers/net/wireless/realtek/rtl8192cu/include/sta_info.h:398: | |
| +__inline static u32 wifi_mac_hash(const u8 *mac) | |
| WARNING: plain inline is preferred over __inline | |
| #150: FILE: drivers/net/wireless/realtek/rtl8192cu/include/sta_info.h:398: | |
| +__inline static u32 wifi_mac_hash(const u8 *mac) | |
| WARNING: line over 80 characters | |
| #159: FILE: drivers/net/wireless/realtek/rtl8192cu/include/sta_info.h:426: | |
| +extern struct sta_info *rtw_get_stainfo(struct sta_priv *pstapriv, const u8 *hwaddr); | |
| CHECK: extern prototypes should be avoided in .h files | |
| #159: FILE: drivers/net/wireless/realtek/rtl8192cu/include/sta_info.h:426: | |
| +extern struct sta_info *rtw_get_stainfo(struct sta_priv *pstapriv, const u8 *hwaddr); | |
| WARNING: storage class should be at the beginning of the declaration | |
| #172: FILE: drivers/net/wireless/realtek/rtl8192cu/include/wifi.h:428: | |
| +__inline static int IS_MCAST(const unsigned char *da) | |
| ERROR: inline keyword should sit between storage class and type | |
| #172: FILE: drivers/net/wireless/realtek/rtl8192cu/include/wifi.h:428: | |
| +__inline static int IS_MCAST(const unsigned char *da) | |
| WARNING: plain inline is preferred over __inline | |
| #172: FILE: drivers/net/wireless/realtek/rtl8192cu/include/wifi.h:428: | |
| +__inline static int IS_MCAST(const unsigned char *da) | |
| WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged | |
| #210: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:583: | |
| +#if LINUX_VERSION_CODE < KERNEL_VERSION(4, 1, 0) | |
| WARNING: Comparisons should place the constant on the right side of the test | |
| #210: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:583: | |
| +#if LINUX_VERSION_CODE < KERNEL_VERSION(4, 1, 0) | |
| ERROR: code indent should use tabs where possible | |
| #213: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:586: | |
| + IEEE80211_BSS_TYPE_ESS, IEEE80211_PRIVACY_ANY);$ | |
| WARNING: please, no spaces at the start of a line | |
| #213: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:586: | |
| + IEEE80211_BSS_TYPE_ESS, IEEE80211_PRIVACY_ANY);$ | |
| WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged | |
| #228: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:714: | |
| +#if LINUX_VERSION_CODE < KERNEL_VERSION(4,2,0) | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #228: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:714: | |
| +#if LINUX_VERSION_CODE < KERNEL_VERSION(4,2,0) | |
| ^ | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #228: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:714: | |
| +#if LINUX_VERSION_CODE < KERNEL_VERSION(4,2,0) | |
| ^ | |
| WARNING: Comparisons should place the constant on the right side of the test | |
| #228: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:714: | |
| +#if LINUX_VERSION_CODE < KERNEL_VERSION(4,2,0) | |
| WARNING: line over 80 characters | |
| #233: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:717: | |
| + cfg80211_disconnected(padapter->pnetdev, 0, NULL, 0, false, GFP_ATOMIC); | |
| ERROR: code indent should use tabs where possible | |
| #235: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:719: | |
| + }$ | |
| WARNING: please, no spaces at the start of a line | |
| #235: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:719: | |
| + }$ | |
| WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged | |
| #252: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:1602: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,0,0)) | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #252: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:1602: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,0,0)) | |
| ^ | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #252: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:1602: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,0,0)) | |
| ^ | |
| WARNING: Comparisons should place the constant on the right side of the test | |
| #252: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:1602: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,0,0)) | |
| WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged | |
| #259: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:1609: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,0,0)) | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #259: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:1609: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,0,0)) | |
| ^ | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #259: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:1609: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,0,0)) | |
| ^ | |
| WARNING: Comparisons should place the constant on the right side of the test | |
| #259: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:1609: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,0,0)) | |
| WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged | |
| #266: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:1616: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,0,0)) | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #266: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:1616: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,0,0)) | |
| ^ | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #266: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:1616: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,0,0)) | |
| ^ | |
| WARNING: Comparisons should place the constant on the right side of the test | |
| #266: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:1616: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,0,0)) | |
| WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged | |
| #273: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:1623: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,0,0)) | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #273: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:1623: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,0,0)) | |
| ^ | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #273: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:1623: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,0,0)) | |
| ^ | |
| WARNING: Comparisons should place the constant on the right side of the test | |
| #273: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:1623: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,0,0)) | |
| WARNING: line over 80 characters | |
| #286: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:2448: | |
| +static int rtw_cfg80211_set_wpa_ie(_adapter *padapter, const u8 *pie, size_t ielen) | |
| WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged | |
| #294: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3118: | |
| +#if (LINUX_VERSION_CODE < KERNEL_VERSION(4,0,0)) | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #294: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3118: | |
| +#if (LINUX_VERSION_CODE < KERNEL_VERSION(4,0,0)) | |
| ^ | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #294: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3118: | |
| +#if (LINUX_VERSION_CODE < KERNEL_VERSION(4,0,0)) | |
| ^ | |
| WARNING: Comparisons should place the constant on the right side of the test | |
| #294: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3118: | |
| +#if (LINUX_VERSION_CODE < KERNEL_VERSION(4,0,0)) | |
| WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged | |
| #304: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3418: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,1,0)) | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #304: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3418: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,1,0)) | |
| ^ | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #304: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3418: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,1,0)) | |
| ^ | |
| WARNING: Comparisons should place the constant on the right side of the test | |
| #304: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3418: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,1,0)) | |
| WARNING: line over 80 characters | |
| #305: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3419: | |
| +static int rtw_cfg80211_add_monitor_if(_adapter *padapter, char *name, unsigned char name_assign_type, struct net_device **ndev) | |
| WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged | |
| #316: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3453: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,1,0)) | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #316: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3453: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,1,0)) | |
| ^ | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #316: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3453: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,1,0)) | |
| ^ | |
| WARNING: Comparisons should place the constant on the right side of the test | |
| #316: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3453: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,1,0)) | |
| WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged | |
| #326: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3520: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,1,0)) | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #326: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3520: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,1,0)) | |
| ^ | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #326: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3520: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,1,0)) | |
| ^ | |
| WARNING: Comparisons should place the constant on the right side of the test | |
| #326: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3520: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,1,0)) | |
| WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged | |
| #336: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3540: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,1,0)) | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #336: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3540: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,1,0)) | |
| ^ | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #336: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3540: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,1,0)) | |
| ^ | |
| WARNING: Comparisons should place the constant on the right side of the test | |
| #336: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3540: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(4,1,0)) | |
| WARNING: line over 80 characters | |
| #337: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3541: | |
| + ret = rtw_cfg80211_add_monitor_if(padapter, (char *)name, name_assign_type, &ndev); | |
| WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged | |
| #358: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3813: | |
| +#if (LINUX_VERSION_CODE < KERNEL_VERSION(3,15,0)) | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #358: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3813: | |
| +#if (LINUX_VERSION_CODE < KERNEL_VERSION(3,15,0)) | |
| ^ | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #358: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3813: | |
| +#if (LINUX_VERSION_CODE < KERNEL_VERSION(3,15,0)) | |
| ^ | |
| WARNING: Comparisons should place the constant on the right side of the test | |
| #358: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3813: | |
| +#if (LINUX_VERSION_CODE < KERNEL_VERSION(3,15,0)) | |
| WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged | |
| #360: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3815: | |
| +#elif (LINUX_VERSION_CODE < KERNEL_VERSION(4,1,0)) | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #360: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3815: | |
| +#elif (LINUX_VERSION_CODE < KERNEL_VERSION(4,1,0)) | |
| ^ | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #360: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3815: | |
| +#elif (LINUX_VERSION_CODE < KERNEL_VERSION(4,1,0)) | |
| ^ | |
| WARNING: Comparisons should place the constant on the right side of the test | |
| #360: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3815: | |
| +#elif (LINUX_VERSION_CODE < KERNEL_VERSION(4,1,0)) | |
| ERROR: code indent should use tabs where possible | |
| #361: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3816: | |
| + const u8 *mac) {$ | |
| WARNING: please, no spaces at the start of a line | |
| #361: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3816: | |
| + const u8 *mac) {$ | |
| ERROR: code indent should use tabs where possible | |
| #363: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3818: | |
| + struct station_del_parameters *params)$ | |
| WARNING: please, no spaces at the start of a line | |
| #363: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3818: | |
| + struct station_del_parameters *params)$ | |
| WARNING: please, no spaces at the start of a line | |
| #365: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3820: | |
| + const u8 *mac = params->mac;$ | |
| WARNING: line over 80 characters | |
| #375: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:3911: | |
| + const u8 *mac, struct station_parameters *params) | |
| WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged | |
| #383: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:4695: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0)) | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #383: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:4695: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0)) | |
| ^ | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #383: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:4695: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0)) | |
| ^ | |
| WARNING: Comparisons should place the constant on the right side of the test | |
| #383: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:4695: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0)) | |
| WARNING: LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged | |
| #396: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:4721: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0)) | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #396: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:4721: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0)) | |
| ^ | |
| ERROR: space required after that ',' (ctx:VxV) | |
| #396: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:4721: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0)) | |
| ^ | |
| WARNING: Comparisons should place the constant on the right side of the test | |
| #396: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/linux/ioctl_cfg80211.c:4721: | |
| +#if (LINUX_VERSION_CODE >= KERNEL_VERSION(3,14,0)) | |
| ERROR: "foo* bar" should be "foo *bar" | |
| #414: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/osdep_service.c:793: | |
| +void _rtw_memcpy(void* dst, const void* src, u32 sz) | |
| ERROR: "foo* bar" should be "foo *bar" | |
| #414: FILE: drivers/net/wireless/realtek/rtl8192cu/os_dep/osdep_service.c:793: | |
| +void _rtw_memcpy(void* dst, const void* src, u32 sz) | |
| ERROR: Missing Signed-off-by: line(s) | |
| total: 48 errors, 54 warnings, 3 checks, 336 lines checked | |
| NOTE: Whitespace errors detected. | |
| You may wish to use scripts/cleanpatch or scripts/cleanfile | |
| 0001-Disable-debug.patch has style problems, please review. | |
| NOTE: If any of the errors are false positives, please report | |
| them to the maintainer, see CHECKPATCH in MAINTAINERS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment