Skip to content

Instantly share code, notes, and snippets.

Embed
What would you like to do?
Brave build installer for Windows with no signing
diff --git a/tools/buildInstaller.js b/tools/buildInstaller.js
index d5e92c017..ed7b9da75 100644
--- a/tools/buildInstaller.js
+++ b/tools/buildInstaller.js
@@ -63,19 +63,19 @@ const raiseError = (errorMessage) => {
if (isDarwin || isWindows) {
const requiredText = 'is required for widevine signing'
if (!process.env.SIGN_WIDEVINE_PASSPHRASE) {
- raiseError('SIGN_WIDEVINE_PASSPHRASE ' + requiredText)
+ // raiseError('SIGN_WIDEVINE_PASSPHRASE ' + requiredText)
}
if (!process.env.SIGN_WIDEVINE_CERT) {
- raiseError('SIGN_WIDEVINE_CERT ' + requiredText)
+ // raiseError('SIGN_WIDEVINE_CERT ' + requiredText)
}
if (!process.env.SIGN_WIDEVINE_KEY) {
- raiseError('SIGN_WIDEVINE_KEY ' + requiredText)
+ // raiseError('SIGN_WIDEVINE_KEY ' + requiredText)
}
// check if widevine script exists
const fs = require('fs')
if (!fs.existsSync('tools/signature_generator.py')) {
- raiseError('`tools/signature_generator.py` ' + requiredText)
+ // raiseError('`tools/signature_generator.py` ' + requiredText)
}
}
@@ -133,7 +133,7 @@ if (isDarwin) {
var cert = process.env.CERT || '../brave-authenticode.pfx'
var certPassword = process.env.CERT_PASSWORD
if (!certPassword) {
- raiseError('Certificate password required. Set environment variable CERT_PASSWORD.')
+ // raiseError('Certificate password required. Set environment variable CERT_PASSWORD.')
}
const getSignCmd = (file) => {
@@ -147,10 +147,11 @@ if (isDarwin) {
const wvExe = buildDir + `/${appName}.exe`
const wvPlugin = buildDir + '/WidevineCdm/_platform_specific/' + widevineCdmArch + '/widevinecdmadapter.dll'
cmds = [
- getSignCmd(wvExe),
- getSignCmd(wvPlugin),
- 'python tools/signature_generator.py --input_file "' + wvExe + '" --flag 1',
- 'python tools/signature_generator.py --input_file "' + wvPlugin + '"'
+ // getSignCmd(wvExe),
+ // getSignCmd(wvPlugin),
+ // 'python tools/signature_generator.py --input_file "' + wvExe + '" --flag 1',
+ // 'python tools/signature_generator.py --input_file "' + wvPlugin + '"'
+ 'echo hi'
]
execute(cmds, {}, (err) => {
if (err) {
@@ -172,7 +173,7 @@ if (isDarwin) {
loadingGif: 'res/brave_splash_installing.gif',
setupIcon: `res/${channel}/brave_installer.ico`,
iconUrl: `https://raw.githubusercontent.com/brave/browser-laptop/coexisted-channels/res/${channel}/app.ico`,
- signWithParams: format('-a -fd sha256 -f "%s" -p "%s"', path.resolve(cert), certPassword),
+ //signWithParams: format('-a -fd sha256 -f "%s" -p "%s"', path.resolve(cert), certPassword),
noMsi: true,
exe: `${appName}.exe`,
setupExe: `${appName}-Setup-${arch}.exe`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.