Skip to content

Instantly share code, notes, and snippets.

@philsof

philsof/miniQuery-challenge-sasha-jeff.md

Last active January 26, 2016 06:18
Show Gist options
  • Save philsof/68b4f7b2853744ab081d to your computer and use it in GitHub Desktop.
Save philsof/68b4f7b2853744ab081d to your computer and use it in GitHub Desktop.
Download ZIP
Code review for pair-Sasha,Jeff for miniQuery-challenge
Raw
miniQuery-challenge-sasha-jeff.md

Good work on releases 0 and 1!

A few notes:

###It Works!###

  • Your code does everything that releases 0 and 1 ask for. Success!

###Formatting###

  • Your JavaScript indentation is perfect. That makes your code very easy to read, which is greatly appreciated. Readability is vital!
  • Be sure to delete any unused code (lines 4, 18-21 in your index.html file; and lines 62, 87 in miniQuery.js)

###Possibly Superfluous Code###

  • I'm not sure what this line of code is accomplishing. Is this line necessary for the assignment on the following line to succeed? It doesn't seem to be needed.
  • Same question for this line.

###If You Can###

  • Try to tackle release 2 as well, if you have time to revisit this challenge. I am sure you can knock that out. Be sure to reference this page, which is also linked to in the challenge instructions.

Good work!

-Phil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment