MPERF-10565.diff - logging to a file that does not exist issue
diff --git a/app/Mage.php b/app/Mage.php | |
index 0e650eebb4f..9c18e222689 100644 | |
--- a/app/Mage.php | |
+++ b/app/Mage.php | |
@@ -798,9 +798,9 @@ public static function log($message, $level = null, $file = '', $forceLog = fals | |
',', | |
(string) self::getConfig()->getNode('dev/log/allowedFileExtensions', Mage_Core_Model_Store::DEFAULT_CODE) | |
); | |
- $logValidator = new Zend_Validate_File_Extension($_allowedFileExtensions); | |
$logDir = self::getBaseDir('var') . DS . 'log'; | |
- if (!$logValidator->isValid($logDir . DS . $file)) { | |
+ $validatedFileExtension = pathinfo($file, PATHINFO_EXTENSION); | |
+ if (!$validatedFileExtension || !in_array($validatedFileExtension, $_allowedFileExtensions)) { | |
return; | |
} | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This comment has been minimized.
I suggest to do not change core code and use an update like this (https://gist.github.com/mehdichaouch/99c67298b5a65f81219c9b69942b6fe7)