Skip to content

Instantly share code, notes, and snippets.

@piotrekkaminski

piotrekkaminski/MAGECLOUD-2515.md

Created February 13, 2019 16:03
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save piotrekkaminski/f2cb5ed8075c173a2897d228419cb3fa to your computer and use it in GitHub Desktop.
Save piotrekkaminski/f2cb5ed8075c173a2897d228419cb3fa to your computer and use it in GitHub Desktop.
Download ZIP
Raw
MAGECLOUD-2515.md

Fixed a Redis configuration issue that incorrectly enabled session locking for Magento Commerce v2.1.11+ and v2.2.1+, which can cause slow performance and timeouts. Now, session locking is disabled by default. The issue was caused by a change in the default behavior of the disable_locking parameter introduced in v1.3.4 of the Redis session handler package, colinmollenhour/php-redis-session-abstract. Background:

In Magento 2.2.1+, 2.1.11+, 2.3.0+ colinmollenhour/php-redis-session-abstract composer dependency has been updated and as a result Redis setting "disable_locking" became disabled. It causes a lot of issues (list of customer tickets) To Do:

This setting should be enabled for all clients by default: in the php-redis-session-abstract-1.3.3 and earlier versions "disable_locking=1" means "use locking" (https://github.com/colinmollenhour/php-redis-session-abstract/blob/v1.3.3/src/Cm/RedisSession/Handler.php#L131) in the php-redis-session-abstract-1.3.4 and higher "disable_locking=1" means "do not use locking" (https://github.com/colinmollenhour/php-redis-session-abstract/blob/v1.3.4/src/Cm/RedisSession/Handler.php#L277)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment