Skip to content

Instantly share code, notes, and snippets.

@pkarman
Last active August 21, 2021 00:04
Show Gist options
  • Star 1 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save pkarman/1ef013541fe7fc6dca66107a77aae553 to your computer and use it in GitHub Desktop.
Save pkarman/1ef013541fe7fc6dca66107a77aae553 to your computer and use it in GitHub Desktop.
Team norms for projects that use GitHub

Norms for teams that use GitHub

This template is designed as a list of examples, questions and/or prompts for teams to discuss as they build norms around using GitHub.

Repo layout

We prefer a directory layout that looks like:

  • README.md
  • CONTRIBUTING.md
  • LICENSE
  • (continue here)

Fork or branch

For our project, we prefer that pull requests originate from (edit to choose one) [forks of the main repo] [branches within the main repo].

Branch naming

When creating branches within a shared repo, our naming conventions look like:

ticketnumber-myinitials-feature-name

Creating PRs

When we create new Pull Requests, we have the following conventions.

WIP

Works in progress can be prefixed with [WIP] in the PR title. We encourage openness and transparency so developers should feel free to create PRs early in the development process and prepend the [WIP] prefix to indicate the the PR code is not yet ready for review.

Assignments

New PRs should be assigned to the person who opens the PR.

Once a PR is ready for review, Reviewers can be assigned based on familiarity with the feature space and/or availability.

Reviewing PRs

Reviewing each other's code is one of the most important collaborative efforts that development teams tackle and can come to define the daily culture of our work. Some common expectations should include:

  • who performs the review
  • how much time should a review take
  • how quickly do we expect a response to our request for a code review

Many other question prompts are available.

Issues

Does the team use the GH issues feature?

  • tags?
  • milestones?
  • templates?

Wiki

Does the team use the GH wiki? What conventions do we follow?

Administration

  • Who are the administrators?
  • How are administrative changes decided and communicated?

Code linting

We use [these linting tools] with [this config].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment