Skip to content

Instantly share code, notes, and snippets.

@pkarman

pkarman/code-review-questions.md

Created April 14, 2021 20:10
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save pkarman/ee373d81bfaad8f4c2c6a1e663e69faf to your computer and use it in GitHub Desktop.
Save pkarman/ee373d81bfaad8f4c2c6a1e663e69faf to your computer and use it in GitHub Desktop.
Download ZIP
things I value in a code review
Raw
code-review-questions.md
  • Are there tests?
  • Are tests clearly testing (at least) the AC?
  • Are variables named helpfully?
  • Are methods and classes named helpfully?
  • Do code quality checks pass?
  • Were any code quality checks disabled?
  • Are comments helpful? (Do they repeat what's in the code, or explain why? prefer the latter)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment