overtone_pr_notes.md

• overtone/overtone#283

  A ten year old PR about sync-event being broken. Does no one actually use sync-event? The diff looks plausible, it adds a bunch of tests as well, but unsurprisingly it no longer applies cleanly.

  What we need here is for someone to open a REPL, verify that sync-event is indeed broken, and if so to rebase this branch on current main and submit a new PR.

• overtone/overtone#287

  Adds the ability to slide to the stringed instrument ns, and an example to demonstrate how it works. Looks cool, some minor code style issues.

  We'd need someone to try it out to make sure it actually works, then we can merge and address any styling issues afterwards.

• overtone/overtone#310

  A rather specific thing, a fix for the Korg nanoKONTROL2. I left a comment, from looking at the code I can see how this would be an issue, but the proposed fix could break existing code. I left a comment proposing an alternative solution. Would be great if someone could make a new PR for that. And even greater if someone who owns a nanoKontrol could actually test it.

• overtone/overtone#331

  Adds a timeout param to sample, so it doesn't time out when loading really big sound files. The diff seems reasonable, it's a bit of change because the param has to be threaded through a number of calls, but looks like the author made some effort to keep things backwards compatible. It has conflicts, so would be great if someone could rebase it, make a fresh PR for it, and also just run the code once so we have one extra pair of eyes confirming that it works.

• overtone/overtone#454

  WIP PR touching the JNA code. Title is "fix internal linux server", but the linked issue is about "Windows 64 bit". I think we can let this rest for the time being, we probably need a broader conversation around the JNA stuff.

• overtone/overtone#459

  Left a comment, as I suspect there might be a better solution. In any case needs a rebase.

• overtone/overtone#460

  Big WIP PR reworking the JNA code, replacing clj-native with techascent's JNA library. Not touching this yet until I've had more time to dig in to the JNA stuff.

• overtone/overtone#466

  Fixes one of the composition examples (clapping-music), looks like some of the freesound links has gone dead. From the comments it seems there's a concern that some of the new samples are "clicky", which someone suggested could be addressed by adding an envelope. Probably still better to have clicky samples than a broken example, would be great if someone could try this out and report back, or maybe even add that suggested envelope around the samples.