Skip to content

Instantly share code, notes, and snippets.

@pokohide
Last active July 21, 2023 09:33
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save pokohide/b310ea180e7de0467360c96debbb8363 to your computer and use it in GitHub Desktop.
Save pokohide/b310ea180e7de0467360c96debbb8363 to your computer and use it in GitHub Desktop.
before_type_castの返り値の型が変わった原因調査用スクリプト
$ git bisect start main v7.0.6
Bisecting: a merge base must be tested
[2b6182cbd68231ed2a26417e3184c3d8ed21c57a] Merge pull request #43764 from eileencodes/fix-name-of-method
$ git bisect run ruby issue.rb
...
Finished in 0.003305s, 302.5719 runs/s, 302.5719 assertions/s.
1 runs, 1 assertions, 1 failures, 0 errors, 0 skips
38141681cc66e8ecd3035b4488e4a21775d635a3 is the first bad commit
commit 38141681cc66e8ecd3035b4488e4a21775d635a3
Author: eileencodes <eileencodes@gmail.com>
Date: Tue May 9 11:19:12 2023 -0400
Revert "Merge pull request #46444 from eileencodes/revert-forgetting-assignment-changes"
This reverts commit 586436d370126322a1470c10c1fde73cf8dc8875, reversing
changes made to 866e053732636e64685a72e22d76e7988d06a000.
This is an unrevert of https://github.com/rails/rails/pull/46282. I
should have reverted the revert sooner but it kept falling off my radar.
Closes #46446
activemodel/lib/active_model/attribute.rb | 13 +++++++++++++
1 file changed, 13 insertions(+)
bisect found first bad commit
# frozen_string_literal: true
require "bundler/inline"
gemfile(true) do
source "https://rubygems.org"
gem "rails", path: "."
gem 'sqlite3'
end
require "active_record"
require "minitest/autorun"
require "logger"
# This connection will do for database-independent bug reports.
ActiveRecord::Base.establish_connection(adapter: "sqlite3", database: ":memory:")
ActiveRecord::Base.logger = Logger.new(STDOUT)
ActiveRecord::Schema.define do
create_table :posts, force: true do |t|
t.integer :foo, default: 1
end
end
class Post < ActiveRecord::Base
enum foo: { x: 1, y: 2 }
end
class BugTest < Minitest::Test
def test_foo
post = Post.create!
assert_equal 1, post.foo_before_type_cast
#=> 1 (v7.0.6)
#=> "1" (v7.1.0)
end
end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment