Skip to content

Instantly share code, notes, and snippets.

@praveev
Last active May 16, 2020 20:31
Show Gist options
  • Save praveev/cd4ef192f0ebd5ad89b3b759cd241860 to your computer and use it in GitHub Desktop.
Save praveev/cd4ef192f0ebd5ad89b3b759cd241860 to your computer and use it in GitHub Desktop.
pull-request template

Description

Please include a summary of the change and why this is needed.

  • [Design Document](paste URL here or delete)
  • [Jira Ticket](paste URL here or delete)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Other - Reason:

Does it affect any of the following

  • CCPA
  • GDPR
  • Downstream System A
  • Downstream System B

Operational Considerations

Verification Process

Please describe how to verify this change in production. Through metrics and logs, or manually if necessary.

Dependencies

List any other changes that must be deployed and enabled before deploying and/or enabling this change, if any.

Debug

How to debug if there are any issues with this code?

Rollback

Are there issues with simply rolling this commit back in production?

Testing

Automated Tests Added (x at least one)

  • Unit
  • Functional
  • Integration
  • End-to-end
  • None - Reason:

Checklist:

  • My code follows the style guidelines in the file or project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment