Skip to content

Instantly share code, notes, and snippets.

@pro100skm
Created October 8, 2018 21:39
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 1 You must be signed in to fork a gist
  • Save pro100skm/334a3e12b269676e330d77321623a8ad to your computer and use it in GitHub Desktop.
Save pro100skm/334a3e12b269676e330d77321623a8ad to your computer and use it in GitHub Desktop.

JarvisPlus audit report

Summary

This is the report from a security audit performed on JarvisPlus by pro100skm.

The audit focused primarily on the security of JarvisPlus contract.

In scope

  1. https://github.com/x-contract/JarvisPlusToken/blob/master/flats/JarvisPlusToken_flat.sol

Findings

In total, 2 issues were reported including:

  • 0 high severity issues.

  • 0 medium severity issues.

  • 1 low severity issues.

  • 1 minor observations.

Security issues

1. Known Issues of ERC20 Standard

Severity: low

Description

approve + transferFrom mechanism allows double Withdrawal attack.

2. Representation note

Severity: minor

Description

'initialAmount' assigns a long number.

Recommendation

Better to change the representation of this number. And write it as below:

uint256 private constant initialAmount = 600000000 * (10 ** uint256(decimals));

Conclusion

There weren't detected any high severity vulnerabilities that can directly hurt the JarvisPlus smart contracts. We highly recommend you to complete other bugbounty before use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment