Skip to content

Instantly share code, notes, and snippets.

@pro100skm

pro100skm/ONEX.md Secret

Last active December 27, 2018 09:50
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 1 You must be signed in to fork a gist
  • Save pro100skm/b2a63e7222dfc76e82b6206818227e5d to your computer and use it in GitHub Desktop.
Save pro100skm/b2a63e7222dfc76e82b6206818227e5d to your computer and use it in GitHub Desktop.
Download ZIP
Raw
ONEX.md

ONEX audit report

Summary

This is the report from a security audit performed on ONEX by pro100skm.

The audit focused primarily on the security of ONEX contract.

In scope

  1. https://github.com/HighlanderNetwork/ONEX-Network/blob/master/contracts/ONEX.sol

Findings

In total, 2 issues were reported including:

  • 0 high severity issues.

  • 1 medium severity issues.

  • 0 low severity issues.

  • 1 minor observations.

Security issues

1. Complexity

Severity: medium

Description

Holders will get bonuses from their balances and all receives that came 3 days before calling mint function. It means that if you get received a lot of tokens at once and 2 days later call mint function, you will lose reward from received tokens only for 2 days.

2. Complexity

Severity: minor

Description

maxMintProofOfStake variable can be represented as percentage (10% - 0.1) instead of makeing additional calculations in line 237.

Conclusion

There weren't detected any high severity vulnerability that can directly hurt the ONEX smart contract.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment