pventuzelo

Go Code Review Comments

This page collects common comments made during reviews of Go code, so that a single detailed explanation can be referred to by shorthands. This is a laundry list of common mistakes, not a style guide.

You can view this as a supplement to http://golang.org/doc/effective_go.html.

Please discuss changes before editing this page, even minor ones. Many people have opinions and this is not the place for edit wars.

pventuzelo

const parser = require("@webassemblyjs/wasm-parser");

function fuzz(buf) {
    try {
        parser.decode(buf, {});
    } catch (e) {
    // Those are "valid" exceptions. we can't catch them in one line as
    if (e.message.indexOf('Unexpected section') !== -1  ||
        e.message.indexOf('Atomic instructions') !== -1 ||
        e.message.indexOf('unknown table') !== -1 ||