Skip to content

Instantly share code, notes, and snippets.

@pvinthemix
Last active October 12, 2018 17:13
Show Gist options
  • Save pvinthemix/5fb03b538f3cfba5fd496eff853715cb to your computer and use it in GitHub Desktop.
Save pvinthemix/5fb03b538f3cfba5fd496eff853715cb to your computer and use it in GitHub Desktop.
Pair to Pair - Jeopardy Feedback - Hillary and Elly.

FeedBack

CodeBase

  • The code is easy to understand in it's current state and follows styling guides
  • Possible redudant code in the daily class with the checkMinimum method and checkWageValidity method are written. Can these methods be combied into one method?
  • Should dailyDouble be it's own class or file?
  • No need to pass in score in the player class constructor because it is explicity set to zero as a default at start.
  • Some confusion with the createRound function and where it is being invoked. Is this intentional? It looks like it gets called on page load. Does this happen before the creation of the player names?

README

  • Readme has link to DTR
  • Needs screenshot of wireframe
  • Start of the project so not much in this area as expected

GITHUB/ISSUES/WORKFLOW

  • Submitted issue for figuring out random question on daily double
  • Possible that logic behind random categories could be logged as an enhancement or issue to fix other methods.
  • Might log more potential issues around creating classes so that it is more visible what part of the project needs help.
  • Presumed that team is working together in-person, as there no comments in pull request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment