Skip to content

Instantly share code, notes, and snippets.

@pybites

pybites/default-arg-anti-pattern.py

Last active December 12, 2020 21:27
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save pybites/749358550803b24018b15cf7dab04b21 to your computer and use it in GitHub Desktop.
Save pybites/749358550803b24018b15cf7dab04b21 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
default-arg-anti-pattern.py
>>> from datetime import datetime
>>> def today(dt=datetime.now()):
... print(dt)
...
>>> today()
2020-12-12 22:18:26.432268
# oops
>>> today()
2020-12-12 22:18:26.432268
>>> today()
2020-12-12 22:18:26.432268
>>> from datetime import datetime
>>> def today(dt=None):
... if dt is None:
... dt = datetime.now()
... print(dt)
...
>>> today()
2020-12-12 22:19:11.617223
# better
>>> today()
2020-12-12 22:19:12.545453
>>> today()
2020-12-12 22:19:14.145179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment