Backfill recurring_invoice_profile_id

backfill.rb

def backfill_recurring_invoice_profile_id
  ids = RecurringInvoiceProfile.select(:id)

  progress_bar = ProgressBar.new(ids.count)

  RecurringInvoiceProfile.select(:id).find_each do |recurring_invoice_profile|
    Invoice.where(recurring_invoice_id: recurring_invoice_profile.id).
      update_all(recurring_invoice_profile_id: recurring_invoice_profile.id)

    progress_bar.increment!
  end
end

Are the recurring_invoice_id and recurring_invoice_profile_id being kept in sync with each other? If so this script looks good.

The only thing I'd add is that I don't think we need to rate limit the scripts any more now we are on Aurora, or at least you could probably have the script run a lot faster. Might be worth doublechecking with ops

@djmb yeah they are being kept in sync with a wee before save hook just now.

Cheers for looking at this.

Ah cool - does that mean the table isn’t in sync with the auto increment key? If so is there a plan to avoid ID clashes in future?

@djmb the auto increment keys are currently in sync between RecurringInvoice#id (old model) and RecurringInvoiceProfile#id (new model) so we shouldn't have an issue with ID clashes in the future.