Skip to content

Instantly share code, notes, and snippets.

View radzak's full-sized avatar
🎯
Focusing

Radosław Krzak radzak

🎯
Focusing
  • MoonPay
  • Poznań, Poland
View GitHub Profile
@radzak
radzak / nitpick-style.toml
Created April 3, 2020 23:53
nitpick-style.toml
["setup.cfg".flake8]
show-source = true
max-line-length = 88
ignore = "D100,D104,D401,RST303,RST304,DAR103,DAR203"
["setup.cfg".isort]
multi_line_output = 3
include_trailing_comma = true
force_grid_wrap = 0
use_parentheses = true
@radzak
radzak / README.md
Last active March 14, 2020 18:45
Fineway - Data Coding Challenge

what you would do next in order to run it in production?

  • well, shortly before I ran out of time, I noticed that my results are different - so I would take care of capitalization (.lower()) and punctuation (", ), ,, etc.)
  • optimize for big files (don't load all the words in the memory into the list, use generator instead)
  • refactor the code, add docstrings, run mypy checker and write unit tests that would check if the output matches the expected result (3 - result.txt)