Skip to content

Instantly share code, notes, and snippets.

@rajivr
Created February 7, 2020 10:36
Show Gist options
  • Save rajivr/556d63448acf39cd21e8bb97e0d401d3 to your computer and use it in GitHub Desktop.
Save rajivr/556d63448acf39cd21e8bb97e0d401d3 to your computer and use it in GitHub Desktop.
Remove `static inline` from `tu_edpt_*` functions
From: Rajiv Ranganath <rajiv.ranganath@atihita.com>
Signed-off-by: Rajiv Ranganath <rajiv.ranganath@atihita.com>
---
src/common/tusb_types.c | 19 +++++++++++++++++++
src/common/tusb_types.h | 15 +++------------
2 files changed, 22 insertions(+), 12 deletions(-)
create mode 100644 src/common/tusb_types.c
diff --git a/src/common/tusb_types.c b/src/common/tusb_types.c
new file mode 100644
index 00000000..8c2c7710
--- /dev/null
+++ b/src/common/tusb_types.c
@@ -0,0 +1,19 @@
+#include "tusb_common.h"
+#include "tusb_types.h"
+
+// Get direction from Endpoint address
+tusb_dir_t tu_edpt_dir(uint8_t addr)
+{
+ return (addr & TUSB_DIR_IN_MASK) ? TUSB_DIR_IN : TUSB_DIR_OUT;
+}
+
+// Get Endpoint number from address
+uint8_t tu_edpt_number(uint8_t addr)
+{
+ return (uint8_t)(addr & (~TUSB_DIR_IN_MASK));
+}
+
+uint8_t tu_edpt_addr(uint8_t num, uint8_t dir)
+{
+ return (uint8_t)(num | (dir ? TUSB_DIR_IN_MASK : 0));
+}
diff --git a/src/common/tusb_types.h b/src/common/tusb_types.h
index c37c19ba..dbb5544e 100644
--- a/src/common/tusb_types.h
+++ b/src/common/tusb_types.h
@@ -437,21 +437,12 @@ static inline uint8_t bm_request_type(uint8_t direction, uint8_t type, uint8_t r
//--------------------------------------------------------------------+
// Get direction from Endpoint address
-static inline tusb_dir_t tu_edpt_dir(uint8_t addr)
-{
- return (addr & TUSB_DIR_IN_MASK) ? TUSB_DIR_IN : TUSB_DIR_OUT;
-}
+tusb_dir_t tu_edpt_dir(uint8_t addr);
// Get Endpoint number from address
-static inline uint8_t tu_edpt_number(uint8_t addr)
-{
- return (uint8_t)(addr & (~TUSB_DIR_IN_MASK));
-}
+uint8_t tu_edpt_number(uint8_t addr);
-static inline uint8_t tu_edpt_addr(uint8_t num, uint8_t dir)
-{
- return (uint8_t)(num | (dir ? TUSB_DIR_IN_MASK : 0));
-}
+uint8_t tu_edpt_addr(uint8_t num, uint8_t dir);
//--------------------------------------------------------------------+
// Descriptor helper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment