Skip to content

Instantly share code, notes, and snippets.

@rdohms
Forked from guilhermeblanco/RpcApi.php
Created February 26, 2012 19:47
Show Gist options
  • Save rdohms/1918623 to your computer and use it in GitHub Desktop.
Save rdohms/1918623 to your computer and use it in GitHub Desktop.
<?php
function validateProducts($products) {
// Check to make sure that our valid fields are in there
$requiredFields = array(
'price',
'name',
'description',
'type',
);
$valid = true;
foreach ($products as $rawProduct) {
$fields = array_keys($rawProduct);
foreach ($requiredFields as $requiredField) {
if (!in_array($requiredField, $fields)) {
$valid = false;
}
}
}
return $valid;
}
?>
// ---------------- REWRITTEN
<?php
function validateProductList($products)
{
$invalidProducts = array_filter($products, 'isInvalidProduct');
return (count($invalidProducts) === 0);
}
function isInvalidProduct($rawProduct)
{
$requiredFields = array('price', 'name', 'description', 'type');
$fields = array_keys($rawProduct);
$missingFields = array_diff($requiredFields, $fields);
return (count($missingFields) > 0);
}
?>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment