Skip to content

Instantly share code, notes, and snippets.

@refack
Last active April 24, 2019 17:58
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save refack/8490362a2dd0dabb444a9e9f3ea1bd98 to your computer and use it in GitHub Desktop.
Save refack/8490362a2dd0dabb444a9e9f3ea1bd98 to your computer and use it in GitHub Desktop.
modernize-use-override
/home/iojs/build/workspace/node-clang-tidy/src/env.h:544:3: warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
~AsyncRequest();
^
override
modernize-use-override
/home/iojs/build/workspace/node-clang-tidy/src/env.h:825:3: warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
~Environment();
^
override
modernize-use-bool-literals
/home/iojs/build/workspace/node-clang-tidy/src/env.h:1253:75: warning: converting integer literal to bool, use bool literal instead [modernize-use-bool-literals]
static_cast<int>(DebugCategory::CATEGORY_COUNT)
bool debug_enabled_[static_cast<int>(DebugCategory::CATEGORY_COUNT)] = {0};
^
false
modernize-use-override
/home/iojs/build/workspace/node-clang-tidy/src/fs_event_wrap.cc:68:3: warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
~FSEventWrap() = default;
^
override
modernize-use-equals-default
/home/iojs/build/workspace/node-clang-tidy/src/inspector/worker_agent.cc:55:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
~ParentInspectorSessionDelegate() override {
^
modernize-use-equals-default
/home/iojs/build/workspace/node-clang-tidy/src/inspector_agent.cc:231:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
~ChannelImpl() override {
^
modernize-deprecated-headers
/home/iojs/build/workspace/node-clang-tidy/src/js_native_api_v8.cc:1:10: warning: inclusion of deprecated C++ header 'limits.h'; consider using 'climits' instead [modernize-deprecated-headers]
#include <limits.h> // INT_MAX
^~~~~~~~~~
<climits>
modernize-deprecated-headers
/home/iojs/build/workspace/node-clang-tidy/src/large_pages/node_large_page.cc:23:10: warning: inclusion of deprecated C++ header 'errno.h'; consider using 'cerrno' instead [modernize-deprecated-headers]
#include <errno.h> // NOLINT(build/include)
^~~~~~~~~
<cerrno>
modernize-deprecated-headers
/home/iojs/build/workspace/node-clang-tidy/src/large_pages/node_large_page.cc:25:10: warning: inclusion of deprecated C++ header 'limits.h'; consider using 'climits' instead [modernize-deprecated-headers]
#include <limits.h> // PATH_MAX
^~~~~~~~~~
<climits>
modernize-deprecated-headers
/home/iojs/build/workspace/node-clang-tidy/src/large_pages/node_large_page.cc:26:10: warning: inclusion of deprecated C++ header 'locale.h'; consider using 'clocale' instead [modernize-deprecated-headers]
#include <locale.h>
^~~~~~~~~~
<clocale>
modernize-deprecated-headers
/home/iojs/build/workspace/node-clang-tidy/src/large_pages/node_large_page.cc:27:10: warning: inclusion of deprecated C++ header 'signal.h'; consider using 'csignal' instead [modernize-deprecated-headers]
#include <signal.h>
^~~~~~~~~~
<csignal>
modernize-deprecated-headers
/home/iojs/build/workspace/node-clang-tidy/src/large_pages/node_large_page.cc:28:10: warning: inclusion of deprecated C++ header 'stdio.h'; consider using 'cstdio' instead [modernize-deprecated-headers]
#include <stdio.h>
^~~~~~~~~
<cstdio>
modernize-deprecated-headers
/home/iojs/build/workspace/node-clang-tidy/src/large_pages/node_large_page.cc:29:10: warning: inclusion of deprecated C++ header 'stdlib.h'; consider using 'cstdlib' instead [modernize-deprecated-headers]
#include <stdlib.h>
^~~~~~~~~~
<cstdlib>
modernize-deprecated-headers
/home/iojs/build/workspace/node-clang-tidy/src/large_pages/node_large_page.cc:30:10: warning: inclusion of deprecated C++ header 'stdint.h'; consider using 'cstdint' instead [modernize-deprecated-headers]
#include <stdint.h>
^~~~~~~~~~
<cstdint>
modernize-deprecated-headers
/home/iojs/build/workspace/node-clang-tidy/src/large_pages/node_large_page.cc:31:10: warning: inclusion of deprecated C++ header 'string.h'; consider using 'cstring' instead [modernize-deprecated-headers]
#include <string.h>
^~~~~~~~~~
<cstring>
modernize-use-emplace
/home/iojs/build/workspace/node-clang-tidy/src/node.cc:712:18: warning: use emplace_back instead of push_back [modernize-use-emplace]
env_argv.push_back(std::string(1, c));
^~~~~~~~~~~~~~~~~~~~~~ ~
emplace_back(
modernize-make-unique
/home/iojs/build/workspace/node-clang-tidy/src/node_main_instance.cc:28:17: warning: use std::make_unique instead [modernize-make-unique]
isolate_data_.reset(new IsolateData(isolate_, event_loop, platform, nullptr));
~^~~~~ ~~~~~~~~~~~~~~~~ ~
= std::make_unique<IsolateData>
modernize-make-unique
/home/iojs/build/workspace/node-clang-tidy/src/node_main_instance.cc:67:17: warning: use std::make_unique instead [modernize-make-unique]
isolate_data_.reset(new IsolateData(isolate_,
~^~~~~ ~~~~~~~~~~~~~~~~
= std::make_unique<IsolateData>
modernize-deprecated-headers
/home/iojs/build/workspace/node-clang-tidy/src/node_object_wrap.h:26:10: warning: inclusion of deprecated C++ header 'assert.h'; consider using 'cassert' instead [modernize-deprecated-headers]
#include <assert.h>
^~~~~~~~~~
<cassert>
modernize-use-equals-default
/home/iojs/build/workspace/node-clang-tidy/src/node_url.cc:82:5: warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
~Value() {}
^ ~~
= default;
modernize-use-override
/home/iojs/build/workspace/node-clang-tidy/src/tracing/traced_value.h:21:3: warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
~TracedValue() = default;
^
override
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment