Created
March 22, 2019 22:39
-
-
Save refack/ce2d10f8364a539c5da3314a777bee3e to your computer and use it in GitHub Desktop.
clang-tidy output
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 71228 warnings and 37 errors generated. | |
| Error while processing /home/iojs/build/workspace/node-clang-tidy/src/tracing/traced_value.h. | |
| /home/iojs/build/workspace/node-clang-tidy/src/debug_utils.h:103:11: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| virtual ~NativeSymbolDebuggingContext() {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/env.h:516:3: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] | |
| AsyncRequest() {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/env.h:517:3: warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override] | |
| ~AsyncRequest(); | |
| ^ | |
| override | |
| /home/iojs/build/workspace/node-clang-tidy/src/env.h:957:20: error: use of undeclared identifier 'ReqWrapBase' [clang-diagnostic-error] | |
| typedef ListHead<ReqWrapBase, &ReqWrapBase::req_wrap_queue_> ReqWrapQueue; | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/env.h:1147:75: warning: converting integer literal to bool, use bool literal instead [modernize-use-bool-literals] | |
| bool debug_enabled_[static_cast<int>(DebugCategory::CATEGORY_COUNT)] = {0}; | |
| ^ | |
| false | |
| /home/iojs/build/workspace/node-clang-tidy/src/fs_event_wrap.cc:87:14: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| FSEventWrap::~FSEventWrap() { | |
| ^ ~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/histogram-inl.h:49:72: warning: the parameter 'fn' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param] | |
| inline void Histogram::Percentiles(std::function<void(double, double)> fn) { | |
| ^ | |
| const & | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector/main_thread_interface.cc:106:17: warning: parameter 'thread' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param] | |
| : thread_(thread), object_id_(object_id) {} | |
| ^ | |
| std::move( ) | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector/main_thread_interface.cc:110:41: warning: the parameter 'thread' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param] | |
| std::shared_ptr<MainThreadHandle> thread, Factory factory) | |
| ^ | |
| const & | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector/main_thread_interface.cc:180:16: warning: parameter 'thread' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param] | |
| : state_(thread, std::bind(MainThreadSessionState::Create, | |
| ^ | |
| std::move( ) | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector/main_thread_interface.cc:197:56: warning: the parameter 'thread' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param] | |
| ThreadSafeDelegate(std::shared_ptr<MainThreadHandle> thread, int object_id) | |
| ^ | |
| const & | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector/main_thread_interface.h:29:11: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| virtual ~Request() {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector/main_thread_interface.h:34:11: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| virtual ~Deletable() {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector/node_string.cc:2:10: error: 'node/inspector/protocol/Protocol.h' file not found [clang-diagnostic-error] | |
| #include "node/inspector/protocol/Protocol.h" | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector/tracing_agent.h:4:10: error: 'node/inspector/protocol/NodeTracing.h' file not found [clang-diagnostic-error] | |
| #include "node/inspector/protocol/NodeTracing.h" | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector/worker_agent.cc:55:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| ~ParentInspectorSessionDelegate() override { | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector/worker_agent.h:4:10: error: 'node/inspector/protocol/NodeWorker.h' file not found [clang-diagnostic-error] | |
| #include "node/inspector/protocol/NodeWorker.h" | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector/worker_inspector.cc:18:42: warning: parameter 'worker_thread' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param] | |
| info_(BuildWorkerTitle(id), url, worker_thread), | |
| ^ | |
| std::move( ) | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector/worker_inspector.cc:59:42: warning: parameter 'parent_thread' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param] | |
| : id_(id), url_(url), parent_thread_(parent_thread), | |
| ^ | |
| std::move( ) | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector/worker_inspector.cc:70:43: warning: parameter 'worker_thread' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param] | |
| new WorkerStartedRequest(id_, url_, worker_thread, waiting)); | |
| ^ | |
| std::move( ) | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector/worker_inspector.h:24:11: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| virtual ~WorkerDelegate() {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector/worker_inspector.h:31:48: warning: parameter 'manager' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param] | |
| : manager_(manager), id_(id) {} | |
| ^ | |
| std::move( ) | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector/worker_inspector.h:46:30: warning: parameter 'worker_thread' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param] | |
| worker_thread(worker_thread) {} | |
| ^ | |
| std::move( ) | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector/worker_inspector.h:74:36: warning: parameter 'thread' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param] | |
| : thread_(thread) {} | |
| ^ | |
| std::move( ) | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector_agent.cc:219:58: warning: the parameter 'main_thread_' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param] | |
| std::shared_ptr<MainThreadHandle> main_thread_, | |
| ^ | |
| const & | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector_agent.cc:231:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| ~ChannelImpl() override { | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector_agent.cc:357:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| ~InspectorTimer() {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector_agent.cc:388:60: warning: the parameter 'client' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param] | |
| int session_id, std::shared_ptr<NodeInspectorClient> client) | |
| ^ | |
| const & | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector_agent.cc:709:16: warning: parameter 'host_port' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param] | |
| host_port_ = host_port; | |
| ^ | |
| std::move( ) | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector_agent.h:33:11: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| virtual ~InspectorSession() {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector_io.cc:198:47: warning: parameter 'queue' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param] | |
| : request_queue_(queue), id_(id) { } | |
| ^ | |
| std::move( ) | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector_io.cc:218:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| ~InspectorIoDelegate() override { | |
| ^ ~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector_io.cc:247:23: warning: parameter 'main_thread' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param] | |
| new InspectorIo(main_thread, path, host_port)); | |
| ^ | |
| std::move( ) | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector_io.cc:247:42: warning: parameter 'host_port' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param] | |
| new InspectorIo(main_thread, path, host_port)); | |
| ^ | |
| std::move( ) | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector_io.cc:257:20: warning: parameter 'main_thread' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param] | |
| : main_thread_(main_thread), | |
| ^ | |
| std::move( ) | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector_io.cc:258:18: warning: parameter 'host_port' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param] | |
| host_port_(host_port), | |
| ^ | |
| std::move( ) | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector_io.cc:321:22: warning: parameter 'queue' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param] | |
| : request_queue_(queue), main_thread_(main_thread), | |
| ^ | |
| std::move( ) | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector_io.cc:321:43: warning: parameter 'main_thread' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param] | |
| : request_queue_(queue), main_thread_(main_thread), | |
| ^ | |
| std::move( ) | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector_socket.cc:159:38: warning: 'rfind' called with a string literal consisting of a single character; consider using the more effective overload accepting a character [performance-faster-string-find] | |
| size_t last_colon_pos = host.rfind(":"); | |
| ^~~ | |
| ':' | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector_socket.cc:162:31: warning: 'rfind' called with a string literal consisting of a single character; consider using the more effective overload accepting a character [performance-faster-string-find] | |
| size_t bracket = host.rfind("]"); | |
| ^~~ | |
| ']' | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector_socket.h:28:13: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| virtual ~Delegate() {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector_socket_server.cc:23:12: error: 'v8_inspector_protocol_json.h' file not found [clang-diagnostic-error] | |
| #include "v8_inspector_protocol_json.h" // NOLINT(build/include_order) | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/inspector_socket_server.h:34:11: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| virtual ~SocketServerDelegate() {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/js_native_api_v8.cc:398:5: warning: 'if' statement is unnecessary; deleting null pointer has no effect [readability-delete-null-pointer] | |
| if (bundle != nullptr) { | |
| ^~~~~~~~~~~~~~~~~~~~~~~~ | |
| /home/iojs/build/workspace/node-clang-tidy/src/js_native_api_v8.h:14:11: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| virtual ~napi_env__() {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/js_native_api_v8.h:169:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| ~Finalizer() { | |
| ^ ~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/memory_tracker.h:110:11: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| virtual ~MemoryRetainer() {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/node.h:251:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| ~MultiIsolatePlatform() override { } | |
| ^ ~~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_api.cc:844:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| ~Work() override { } | |
| ^ ~~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_crypto.cc:5717:11: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| virtual ~KeyPairGenerationConfig() {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_dtrace.cc:147:3: error: use of undeclared identifier 'NODE_NET_SERVER_CONNECTION'; did you mean 'DTRACE_NET_SERVER_CONNECTION'? [clang-diagnostic-error] | |
| NODE_NET_SERVER_CONNECTION(&conn, conn.remote, conn.port, conn.fd); | |
| ^~~~~~~~~~~~~~~~~~~~~~~~~~ | |
| DTRACE_NET_SERVER_CONNECTION | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_dtrace.cc:142:6: note: 'DTRACE_NET_SERVER_CONNECTION' declared here | |
| void DTRACE_NET_SERVER_CONNECTION(const FunctionCallbackInfo<Value>& args) { | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_dtrace.cc:147:37: error: too many arguments provided to function-like macro invocation [clang-diagnostic-error] | |
| NODE_NET_SERVER_CONNECTION(&conn, conn.remote, conn.port, conn.fd); | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_dtrace.cc:37:9: note: macro 'NODE_NET_SERVER_CONNECTION' defined here | |
| #define NODE_NET_SERVER_CONNECTION(arg0) | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_dtrace.cc:156:3: error: use of undeclared identifier 'NODE_NET_STREAM_END'; did you mean 'DTRACE_NET_STREAM_END'? [clang-diagnostic-error] | |
| NODE_NET_STREAM_END(&conn, conn.remote, conn.port, conn.fd); | |
| ^~~~~~~~~~~~~~~~~~~ | |
| DTRACE_NET_STREAM_END | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_dtrace.cc:151:6: note: 'DTRACE_NET_STREAM_END' declared here | |
| void DTRACE_NET_STREAM_END(const FunctionCallbackInfo<Value>& args) { | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_dtrace.cc:156:30: error: too many arguments provided to function-like macro invocation [clang-diagnostic-error] | |
| NODE_NET_STREAM_END(&conn, conn.remote, conn.port, conn.fd); | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_dtrace.cc:39:9: note: macro 'NODE_NET_STREAM_END' defined here | |
| #define NODE_NET_STREAM_END(arg0) | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_dtrace.cc:189:3: error: use of undeclared identifier 'NODE_HTTP_SERVER_REQUEST'; did you mean 'DTRACE_HTTP_SERVER_REQUEST'? [clang-diagnostic-error] | |
| NODE_HTTP_SERVER_REQUEST(&req, &conn, conn.remote, conn.port, req.method, \ | |
| ^~~~~~~~~~~~~~~~~~~~~~~~ | |
| DTRACE_HTTP_SERVER_REQUEST | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_dtrace.cc:159:6: note: 'DTRACE_HTTP_SERVER_REQUEST' declared here | |
| void DTRACE_HTTP_SERVER_REQUEST(const FunctionCallbackInfo<Value>& args) { | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_dtrace.cc:189:41: error: too many arguments provided to function-like macro invocation [clang-diagnostic-error] | |
| NODE_HTTP_SERVER_REQUEST(&req, &conn, conn.remote, conn.port, req.method, \ | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_dtrace.cc:29:9: note: macro 'NODE_HTTP_SERVER_REQUEST' defined here | |
| #define NODE_HTTP_SERVER_REQUEST(arg0, arg1) | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_dtrace.cc:199:3: error: use of undeclared identifier 'NODE_HTTP_SERVER_RESPONSE'; did you mean 'DTRACE_HTTP_SERVER_RESPONSE'? [clang-diagnostic-error] | |
| NODE_HTTP_SERVER_RESPONSE(&conn, conn.remote, conn.port, conn.fd); | |
| ^~~~~~~~~~~~~~~~~~~~~~~~~ | |
| DTRACE_HTTP_SERVER_RESPONSE | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_dtrace.cc:194:6: note: 'DTRACE_HTTP_SERVER_RESPONSE' declared here | |
| void DTRACE_HTTP_SERVER_RESPONSE(const FunctionCallbackInfo<Value>& args) { | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_dtrace.cc:199:36: error: too many arguments provided to function-like macro invocation [clang-diagnostic-error] | |
| NODE_HTTP_SERVER_RESPONSE(&conn, conn.remote, conn.port, conn.fd); | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_dtrace.cc:31:9: note: macro 'NODE_HTTP_SERVER_RESPONSE' defined here | |
| #define NODE_HTTP_SERVER_RESPONSE(arg0) | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_dtrace.cc:238:3: error: use of undeclared identifier 'NODE_HTTP_CLIENT_REQUEST'; did you mean 'DTRACE_HTTP_CLIENT_REQUEST'? [clang-diagnostic-error] | |
| NODE_HTTP_CLIENT_REQUEST(&req, &conn, conn.remote, conn.port, req.method, \ | |
| ^~~~~~~~~~~~~~~~~~~~~~~~ | |
| DTRACE_HTTP_CLIENT_REQUEST | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_dtrace.cc:203:6: note: 'DTRACE_HTTP_CLIENT_REQUEST' declared here | |
| void DTRACE_HTTP_CLIENT_REQUEST(const FunctionCallbackInfo<Value>& args) { | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_dtrace.cc:238:41: error: too many arguments provided to function-like macro invocation [clang-diagnostic-error] | |
| NODE_HTTP_CLIENT_REQUEST(&req, &conn, conn.remote, conn.port, req.method, \ | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_dtrace.cc:33:9: note: macro 'NODE_HTTP_CLIENT_REQUEST' defined here | |
| #define NODE_HTTP_CLIENT_REQUEST(arg0, arg1) | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_dtrace.cc:248:3: error: use of undeclared identifier 'NODE_HTTP_CLIENT_RESPONSE'; did you mean 'DTRACE_HTTP_CLIENT_RESPONSE'? [clang-diagnostic-error] | |
| NODE_HTTP_CLIENT_RESPONSE(&conn, conn.remote, conn.port, conn.fd); | |
| ^~~~~~~~~~~~~~~~~~~~~~~~~ | |
| DTRACE_HTTP_CLIENT_RESPONSE | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_dtrace.cc:243:6: note: 'DTRACE_HTTP_CLIENT_RESPONSE' declared here | |
| void DTRACE_HTTP_CLIENT_RESPONSE(const FunctionCallbackInfo<Value>& args) { | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_dtrace.cc:248:36: error: too many arguments provided to function-like macro invocation [clang-diagnostic-error] | |
| NODE_HTTP_CLIENT_RESPONSE(&conn, conn.remote, conn.port, conn.fd); | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_dtrace.cc:35:9: note: macro 'NODE_HTTP_CLIENT_RESPONSE' defined here | |
| #define NODE_HTTP_CLIENT_RESPONSE(arg0) | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_file.cc:684:3: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] | |
| FSReqWrapSync() {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_http2.h:1211:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| ~Headers() {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_http2.h:1232:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| ~Origins() {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_i18n.cc:155:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| ~ConverterObject() override {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_options.h:50:11: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| virtual ~Options() {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_options.h:233:11: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| virtual ~OptionsParser() {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_options.h:331:13: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| virtual ~BaseOptionField() {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_perf.h:76:11: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| virtual ~PerformanceEntry() { } | |
| ^ ~~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_perf_common.h:74:3: error: no template named 'AliasedBuffer' [clang-diagnostic-error] | |
| AliasedBuffer<uint8_t, v8::Uint8Array> root; | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_perf_common.h:75:3: error: no template named 'AliasedBuffer' [clang-diagnostic-error] | |
| AliasedBuffer<double, v8::Float64Array> milestones; | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_perf_common.h:76:3: error: no template named 'AliasedBuffer' [clang-diagnostic-error] | |
| AliasedBuffer<uint32_t, v8::Uint32Array> observers; | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_platform.h:27:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| ~TaskQueue() {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_platform.h:130:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| ~NodePlatform() override {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_process.h:20:39: error: unknown type name 'Environment' [clang-diagnostic-error] | |
| v8::MaybeLocal<v8::Value> ProcessEmit(Environment* env, | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_process.h:24:43: error: unknown type name 'Environment' [clang-diagnostic-error] | |
| v8::Maybe<bool> ProcessEmitWarningGeneric(Environment* env, | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_process.h:29:36: error: unknown type name 'Environment' [clang-diagnostic-error] | |
| v8::Maybe<bool> ProcessEmitWarning(Environment* env, const char* fmt, ...); | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_process.h:30:47: error: unknown type name 'Environment' [clang-diagnostic-error] | |
| v8::Maybe<bool> ProcessEmitDeprecationWarning(Environment* env, | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_process.h:35:5: error: unknown type name 'Environment' [clang-diagnostic-error] | |
| Environment* env, | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_report.cc:331:22: warning: 'find' called with a string literal consisting of a single character; consider using the more effective overload accepting a character [performance-faster-string-find] | |
| int line = ss.find("\n"); | |
| ^~~~ | |
| '\n' | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_report.cc:340:20: warning: 'find' called with a string literal consisting of a single character; consider using the more effective overload accepting a character [performance-faster-string-find] | |
| line = ss.find("\n"); | |
| ^~~~ | |
| '\n' | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_report.cc:348:22: warning: 'find' called with a string literal consisting of a single character; consider using the more effective overload accepting a character [performance-faster-string-find] | |
| line = ss.find("\n"); | |
| ^~~~ | |
| '\n' | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_root_certs.h:4:1: error: expected unqualified-id [clang-diagnostic-error] | |
| "-----BEGIN CERTIFICATE-----\n" | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_serdes.cc:36:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| ~SerializerContext() override {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_serdes.cc:71:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| ~DeserializerContext() override {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_url.cc:82:5: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| ~Value() {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_v8_platform-inl.h:75:3: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| ~NodeTraceStateObserver() override {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_win32_etw_provider.cc:110:48: warning: use nullptr [modernize-use-nullptr] | |
| NODE_V8SYMBOL_REMOVE(jevent->code_start, 0); | |
| ^ | |
| nullptr | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_win32_etw_provider.h:28:10: error: 'evntprov.h' file not found [clang-diagnostic-error] | |
| #include <evntprov.h> | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/node_worker.cc:67:25: warning: parameter 'per_isolate_opts' is passed by value and only copied once; consider moving it to avoid unnecessary copies [performance-unnecessary-value-param] | |
| per_isolate_opts_(per_isolate_opts), | |
| ^ | |
| std::move( ) | |
| /home/iojs/build/workspace/node-clang-tidy/src/req_wrap-inl.h:15:24: error: member reference base type 'node::Environment::ReqWrapQueue' (aka 'int') is not a structure or union [clang-diagnostic-error] | |
| env->req_wrap_queue()->PushBack(this); | |
| ^ | |
| /home/iojs/build/workspace/node-clang-tidy/src/req_wrap.h:17:11: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| virtual ~ReqWrapBase() {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/spawn_sync.cc:53:26: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] | |
| SyncProcessOutputBuffer::SyncProcessOutputBuffer() { | |
| ^ ~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/stream_base.h:39:11: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| virtual ~StreamReq() {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/tracing/agent.h:25:11: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| virtual ~AsyncTraceWriter() {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/tracing/agent.h:51:10: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] | |
| inline AgentWriterHandle() {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/tracing/traced_value.cc:116:14: warning: use '= default' to define a trivial destructor [modernize-use-equals-default] | |
| TracedValue::~TracedValue() {} | |
| ^ ~~ | |
| = default; | |
| /home/iojs/build/workspace/node-clang-tidy/src/util.h:426:3: warning: use '= default' to define a trivial default constructor [modernize-use-equals-default] | |
| ArrayBufferViewContents() {} | |
| ^ ~~ | |
| = default; | |
| Suppressed 71157 warnings (71123 in non-user code, 34 with check filters). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment