Skip to content

Instantly share code, notes, and snippets.

@rexagod
Last active June 6, 2020 21:18
Show Gist options
  • Save rexagod/50e84373d53fc0ccb134b8fb08416d1a to your computer and use it in GitHub Desktop.
Save rexagod/50e84373d53fc0ccb134b8fb08416d1a to your computer and use it in GitHub Desktop.
Progress on HTTP2 and HTTP[S] Compat Tracking Issue

Fixes: nodejs/node#29829

  1. nodejs/node#33162
  2. Expected behaviour
  3. Expected behaviour
  4. Expected behaviour
  5. nodejs/node#33161
  6. Expected behaviour
  7. nodejs/node#33763
  8. nodejs/node#33188
  9. nodejs/node#33506
  10. nodejs/node#33506
  11. nodejs/node#33506
  12. nodejs/node#33183
  13. nodejs/node#33160
  14. nodejs/node#31818
  15. nodejs/node#30964
  16. nodejs/node#33155
  17. nodejs/node#33146
  18. Expected behaviour
  19. Expected behaviour
  20. Expected behaviour
  21. nodejs/node#33144
  22. Expected behaviour
  23. nodejs/node#33568
  24. Expected behaviour
  25. Expected behaviour
  26. [Expected behaviour]
  27. nodejs/node#29229
  28. [Expected behaviour]
  29. nodejs/node#24347
  30. nodejs/node#29529
  31. nodejs/node#32937
  32. [Bug already fixed and cannot be reproduced] (see expressjs/compression#128 (comment)). The following code snippet, close to sogaani's was used to confirm this.
const server = http2.createServer((req, res) => {
	res.setHeader('Content-Type', 'text/plain')
	res.writeHead(304)
	res.write('a');
	res.end()
});
server.listen(0, () => {
	const client = http2.connect(`http://localhost:${server.address().port}`);
	const request = client.request()
	request.on('data', () => {})
	request.on('end', () => {
		client.close();
		server.close();
	})
})
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment