Skip to content

Instantly share code, notes, and snippets.

@riordant

riordant/hexens_gearbox_followup.md

Created February 26, 2024 15:34
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save riordant/bb2a338501b6e65454bf4d44261e7e3c to your computer and use it in GitHub Desktop.
Save riordant/bb2a338501b6e65454bf4d44261e7e3c to your computer and use it in GitHub Desktop.
Download ZIP
Hexens Audit: GearboxV3Strategy: Follow Up
Raw
hexens_gearbox_followup.md

SPOOL3-4 - IMPLEMENT BEFOREDEPOSITCHECK

SPOOL3-2 - REDUNDANT SAFEAPPROVE USAGE

  • Commit: N/A
  • Description:
    • This optimization is acknowledged; However, on review of this issue, we have decided to not implement a change. The optimization is a non-security related change to code implemented by all strategies, including ones already deployed (the change is for Strategy.sol). As a result, we would have to maintain two versions of Strategy.sol in the codebase (existing one for already deployed strategies, and a newer one with these changes). We would rather not maintain two versions of Strategy.sol in the codebase at this point, unless there is a security related concern.

SPOOL2-6 - _CALCULATEYIELDPERCENTAGE FUNCTION CAN BE SIMPLIFIED

  • Commit: N/A
  • Description:
    • This optimisation is acknowledged; However, on review of this issue, we have decided to not implement a change, due to the same reasons outlined in issue 3-2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment