AR Loop test

ar_loop.rb

# 1. Briefly explain what the following code does.
# 2. Is there anything wrong with it?
# 3. How would you resolve the problems (if any exist)? 
# Assume League, Team, Player models
# League <has_many> teams
# Team <has_many> players
# Player has boolean column all_star

def all_stars(league_name)
  league = League.find_by_name league_name
  all_stars = []
  league.teams.each do |team|
     team.players.each do |player|
       all_stars << player if player.all_star?
     end
  end
  all_stars
end