Skip to content

Instantly share code, notes, and snippets.

View rjlasko's full-sized avatar

Robert Lasko rjlasko

View GitHub Profile
@dadatuputi
dadatuputi / zfs_smart.sh
Last active February 12, 2024 16:13
Run SMART tests on a ZFS pool
#!/bin/bash
usage() { echo "Usage: $0 -p <POOL> (-s|-l)" 1>&2; exit 1; }
while getopts ":p:sl" o; do
case "${o}" in
p)
p=${OPTARG}
;;
s)
@skingsland
skingsland / GithubPullRequestDeficiencies.md
Last active April 1, 2022 05:04
Reasons why Crucible/Fisheye is better than Github (Enterprise) Pull Requests for reviewing code

GENERAL:

  • You can't include commits from different repos in a single code review using github pull requests, whereas you can with Crucible code reviews.
  • It's risky to use a pull request for code that isn't ready to be merged yet. What if someone doesn't see the "DON'T MERGE" comment/title, and clicks the big green merge button?

VIEWING:

  • You can't adjust the line width in which files are displayed, even if you make your browser window wider than the page. Some XML/HTML content extends well past 80 characters.
    • There are numerous Chrome extensions which purport to provide this feature, but I haven't been able to get any of them to work for Github:Enterprise.
  • There is no toggle in the Github UI that lets you ignore white space, so if a change involved indenting a lot of lines, you'll have a hard time figuring out what changed. In Crucible, you can choose to ignore white space.
  • You can add ?w=1 to any diff URL to ignore whitespace, however. Not sure why Github hides this behind a [secret](h