magento-1.9.0.0-order_status_visible_on_front-issue24074.diff

Index: app/code/core/Mage/Sales/Model/Order/Config.php
===================================================================
--- app/code/core/Mage/Sales/Model/Order/Config.php	(revision 47050)
+++ app/code/core/Mage/Sales/Model/Order/Config.php	(working copy)
@@ -171,7 +171,7 @@
             foreach ($this->getNode('states')->children() as $state) {
                 $name = $state->getName();
                 $this->_states['all'][] = $name;
-                if ($state->visible_on_front){
+                if ((int)$state->visible_on_front){
                     $this->_states['visible'][] = $name;
                 }
                 else {
Index: app/code/core/Mage/Sales/etc/config.xml
===================================================================
--- app/code/core/Mage/Sales/etc/config.xml	(revision 47050)
+++ app/code/core/Mage/Sales/etc/config.xml	(working copy)
@@ -646,48 +646,49 @@
                         <statuses>
                             <pending default="1"/>
                         </statuses>
-                        <visible_on_front/>
+                        <visible_on_front>1</visible_on_front>
                     </new>
                     <pending_payment translate="label">
                         <label>Pending Payment</label>
                         <statuses>
                             <pending_payment default="1"/>
                         </statuses>
+                        <visible_on_front>0</visible_on_front>
                     </pending_payment>
                     <processing translate="label">
                         <label>Processing</label>
                         <statuses>
                             <processing default="1"/>
                         </statuses>
-                        <visible_on_front/>
+                        <visible_on_front>1</visible_on_front>
                     </processing>
                     <complete translate="label">
                         <label>Complete</label>
                         <statuses>
                             <complete default="1"/>
                         </statuses>
-                        <visible_on_front/>
+                        <visible_on_front>1</visible_on_front>
                     </complete>
                     <closed translate="label">
                         <label>Closed</label>
                         <statuses>
                             <closed default="1"/>
                         </statuses>
-                        <visible_on_front/>
+                        <visible_on_front>1</visible_on_front>
                     </closed>
                     <canceled translate="label">
                         <label>Canceled</label>
                         <statuses>
                             <canceled default="1"/>
                         </statuses>
-                        <visible_on_front/>
+                        <visible_on_front>1</visible_on_front>
                     </canceled>
                     <holded translate="label">
                         <label>On Hold</label>
                         <statuses>
                             <holded default="1"/>
                         </statuses>
-                        <visible_on_front/>
+                        <visible_on_front>1</visible_on_front>
                     </holded>
                     <payment_review translate="label">
                         <label>Payment Review</label>
@@ -695,7 +696,7 @@
                             <payment_review default="1"/>
                             <fraud/>
                         </statuses>
-                        <visible_on_front/>
+                        <visible_on_front>1</visible_on_front>
                     </payment_review>
                 </states>
             </order>