Navigation Menu

Skip to content

Instantly share code, notes, and snippets.

@roberth
Created June 1, 2021 08:50
Show Gist options
  • Star 1 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save roberth/d531f7a5b8b2aaa1568e0f42699224ec to your computer and use it in GitHub Desktop.
Save roberth/d531f7a5b8b2aaa1568e0f42699224ec to your computer and use it in GitHub Desktop.
Why no ๐Ÿ‘Ž reaction?

Why no ๐Ÿ‘Ž reaction?

The main problem with the ๐Ÿ‘Ž reaction is that it does not carry any constructive feedback or explanation.

In some cases, it is added to a pull request early on, before the author has had a chance to improve their proposal. The person placing the reaction often will not receive a notification of the improvements and even if they did, they may forget to remove the ๐Ÿ‘Ž.

These effects are not obvious to the author or the person reacting; let alone to the reader. This causes friction for everyone involved.

But I don't want to add noise!

If your argumentation has already been given by someone else, give their comment a ๐Ÿ‘. That way, it's clear why you didn't like the pr at first and it allows the author to address the issue.

If the reactions stick around on a comment, that's not so bad, because it's quite clear that the issue in the comment may be resolved later on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment