rocketnia/compound-codegen.md

## compound-codegen.md

      
    Raw
  

              compound-codegen.md
            
          
    I find compound unquoted expressions to be pretty good for the readability of a code generator. I think this is a good example (from the current version of html-render.rkt):
`(div ([class ,(if top?
                   "tocviewlist tocviewlisttopspace"
                   "tocviewlist")])
   ,(if top? `(div ([class "tocviewtitle"]) ,header) header)
   ,(if (null? children)
      ""
      `(div ([class ,(cond
                      [(and top? last?) "tocviewsublistonly"]
                      [top? "tocviewsublisttop"]
                      [last? "tocviewsublistbottom"]
                      [else "tocviewsublist"])]
             [style ,(format "display: ~a;" (if expand? 'block 'none))]
             [id ,id])
         (table ([cellspacing "0"] [cellpadding "0"])
           ,@(for/list ([c children])
               (let-values ([(t n) (toc-item->title+num c #t)])
                 `(tr () (td ([align "right"]) ,@n) (td () ,@t))))))))
From that, I can read off the general structure of the generated code:
tocviewlist
  tocviewtitle (optional wrapper)
    header
  tocviewsublist (optional)
    table
      tr (multiple)
        td
        td

Let's say we pull out each of the unquoted compound expressions into its own definition so that we're only unquoting simple variables. I'll try to be fair and do this in as readable a way as I can imagine, without unnecessarily changing other aspects of the original code.
(define class
  (if top?
      "tocviewlist tocviewlisttopspace"
      "tocviewlist"))

(define title
  (if top? `(div ([class "tocviewtitle"]) ,header) header))

(define (generate-sublist)
  
  (define class
    (cond
     [(and top? last?) "tocviewsublistonly"]
     [top? "tocviewsublisttop"]
     [last? "tocviewsublistbottom"]
     [else "tocviewsublist"]))
  
  (define style (format "display: ~a;" (if expand? 'block 'none)))
  
  (define rows
    (for/list ([c children])
      (let-values ([(t n) (toc-item->title+num c #t)])
        `(tr () (td ([align "right"]) ,@n) (td () ,@t)))))
  
  `(div ([class ,class]
         [style ,style]
         [id ,id])
     (table ([cellspacing "0"] [cellpadding "0"])
       ,@rows)))

(define sublist
  (if (null? children)
    ""
    (generate-sublist)))

`(div ([class ,class])
   ,title
   ,sublist)
Now, if I look for the same landmarks in the code, they're all out of order:
class :=
  tocviewlist

title :=
  tocviewtitle (optional wrapper)
    header

sublist (optional) := {
  class :=
    tocviewsublist
  
  rows :=
    tr (multiple)
      td
      td
  
  class
    table
      rows
}

class
  title
  sublist

I have to do a lot of reconstruction in my mind to get a picture of what the final document would look like.