`x/gov` audit

gov-audit.md

x/gov audit

The Celestia upgrade module should not have a message handler for legacy or non-legacy governance proposals.

Legacy gov proposal

I verified that it is possible to submit a legacy governance proposal via

$ celestia-appd tx gov submit-legacy-proposal --title="Test Proposal" --description="My awesome proposal" --type="Text" --deposit="10utia" --from validator --home $CELESTIA_APP_HOME --fees 21000utia
auth_info:
  fee:
    amount:
    - amount: "21000"
      denom: utia
    gas_limit: "210000"
    granter: ""
    payer: ""
  signer_infos: []
  tip: null
body:
  extension_options: []
  memo: ""
  messages:
  - '@type': /cosmos.gov.v1beta1.MsgSubmitProposal
    content:
      '@type': /cosmos.gov.v1beta1.TextProposal
      description: My awesome proposal
      title: Test Proposal
    initial_deposit:
    - amount: "10"
      denom: utia
    proposer: celestia1xq74xr0jpglx0vx7v77ar34w6fdv9nxhmgkmn5
  non_critical_extension_options: []
  timeout_height: "0"
signatures: []
confirm transaction before signing and broadcasting [y/N]: y
code: 0
codespace: ""
data: ""
events: []
gas_used: "0"
gas_wanted: "0"
height: "0"
info: ""
logs: []
raw_log: '[]'
timestamp: ""
tx: null
txhash: 8F5A709D6B743CD9A721E4C38FEE2265A8F71BF7657185F75B7AE069A1CC7EAD

and the legacy proposal failed to execute:

$ ./build/celestia-appd query tx 8F5A709D6B743CD9A721E4C38FEE2265A8F71BF7657185F75B7AE069A1CC7EAD
code: 9
codespace: gov
data: ""
events:
- attributes:
  - index: true
    key: c3BlbmRlcg==
    value: Y2VsZXN0aWExeHE3NHhyMGpwZ2x4MHZ4N3Y3N2FyMzR3NmZkdjlueGhtZ2ttbjU=
  - index: true
    key: YW1vdW50
    value: MjEwMDB1dGlh
  type: coin_spent
- attributes:
  - index: true
    key: cmVjZWl2ZXI=
    value: Y2VsZXN0aWExN3hwZnZha20yYW1nOTYyeWxzNmY4NHoza2VsbDhjNWxwbmpzM3M=
  - index: true
    key: YW1vdW50
    value: MjEwMDB1dGlh
  type: coin_received
- attributes:
  - index: true
    key: cmVjaXBpZW50
    value: Y2VsZXN0aWExN3hwZnZha20yYW1nOTYyeWxzNmY4NHoza2VsbDhjNWxwbmpzM3M=
  - index: true
    key: c2VuZGVy
    value: Y2VsZXN0aWExeHE3NHhyMGpwZ2x4MHZ4N3Y3N2FyMzR3NmZkdjlueGhtZ2ttbjU=
  - index: true
    key: YW1vdW50
    value: MjEwMDB1dGlh
  type: transfer
- attributes:
  - index: true
    key: c2VuZGVy
    value: Y2VsZXN0aWExeHE3NHhyMGpwZ2x4MHZ4N3Y3N2FyMzR3NmZkdjlueGhtZ2ttbjU=
  type: message
- attributes:
  - index: true
    key: ZmVl
    value: MjEwMDB1dGlh
  - index: true
    key: ZmVlX3BheWVy
    value: Y2VsZXN0aWExeHE3NHhyMGpwZ2x4MHZ4N3Y3N2FyMzR3NmZkdjlueGhtZ2ttbjU=
  type: tx
- attributes:
  - index: true
    key: YWNjX3NlcQ==
    value: Y2VsZXN0aWExeHE3NHhyMGpwZ2x4MHZ4N3Y3N2FyMzR3NmZkdjlueGhtZ2ttbjUvMQ==
  type: tx
- attributes:
  - index: true
    key: c2lnbmF0dXJl
    value: ZDh5U0haUTZYWlZ3VjVJd2VzUkRtcW85RTE0cU1tYi9RYkZ5cktEdFdBb3d2SEZ5MW1UZDdxTWw3QnVtWk1EZDVOVHpBZkgxbDhPb1hyZ2hKd296UGc9PQ==
  type: tx
gas_used: "64350"
gas_wanted: "210000"
height: "21"
info: ""
logs: []
raw_log: 'failed to execute message; message index: 0: gov: no handler exists for
  proposal type: no handler exists for proposal type'
timestamp: "2023-06-30T20:21:59Z"
tx:
  '@type': /cosmos.tx.v1beta1.Tx
  auth_info:
    fee:
      amount:
      - amount: "21000"
        denom: utia
      gas_limit: "210000"
      granter: ""
      payer: ""
    signer_infos:
    - mode_info:
        single:
          mode: SIGN_MODE_DIRECT
      public_key:
        '@type': /cosmos.crypto.secp256k1.PubKey
        key: A7c4Vp3cIOl4oX+GK9AxaYLc0BcimUo/MK2wcbLKSC+z
      sequence: "1"
    tip: null
  body:
    extension_options: []
    memo: ""
    messages:
    - '@type': /cosmos.gov.v1beta1.MsgSubmitProposal
      content:
        '@type': /cosmos.gov.v1beta1.TextProposal
        description: My awesome proposal
        title: Test Proposal
      initial_deposit:
      - amount: "10"
        denom: utia
      proposer: celestia1xq74xr0jpglx0vx7v77ar34w6fdv9nxhmgkmn5
    non_critical_extension_options: []
    timeout_height: "0"
  signatures:
  - d8ySHZQ6XZVwV5IwesRDmqo9E14qMmb/QbFyrKDtWAowvHFy1mTd7qMl7BumZMDd5NTzAfH1l8OoXrghJwozPg==
txhash: 8F5A709D6B743CD9A721E4C38FEE2265A8F71BF7657185F75B7AE069A1CC7EAD