Skip to content

Instantly share code, notes, and snippets.

View rsmelo92's full-sized avatar
🌎

Rafael Melo rsmelo92

🌎
View GitHub Profile
// BEFORE
class Person {
get courses() {
return this.courses;
}
set courses(courseList) {
this.courses = courseList;
}
}
// BEFORE
const organization = { name: "Acme Goosberries", country: "GB" };
// AFTER
class Organization {
constructor(data) {
this.name = data.name;
this.country = data.country;
}
get name() {
//BEFORE
const orderData = orderString.split(/\s+/);
const productPrice = priceList[orderData[0].split("-")[1]];
const orderPrice = parseInt(orderData[1]) * productPrice;
//AFTER
const orderRecord = parseOrder(order);
const orderPrice = price(orderRecord, priceList);
function parseOrder(order) {
//BEFORE
function base(reading) {...}
function taxableCharge(reading) {...}
//AFTER
function base(reading) {...}
function taxableCharge(reading) {...}
function enrichReading(readingArgs) {
return {
//BEFORE
function base(reading) {...}
function taxableCharge(reading) {...}
function calculateBaseCharge(reading) {...}
//AFTER
class Reading {
base() {...}
taxableCharge() {...}
calculateBaseCharge() {...}
//BEFORE
function amountInvoiced(startDate, endDate) {...}
function amountReceived(startDate, endDate) {...}
function amountOverdue(startDate, endDate) {...}
//AFTER
function amountInvoiced(dateRage) {...}
function amountReceived(dateRage) {...}
function amountOverdue(dateRage) {...}
//BEFORE
const a = height * width;
//AFTER
const area = height * width;
//BEFORE
let defaultOwner = { firstName: "Martin", lastName: "Fowler" };
function spaceshipOwner(spaceship) {
defaultOwner = {firstName: "Rebecca", lastName: "Parsons"};
spaceship.owner = defaultOwner;
}
//AFTER
let defaultOwnerData = {firstName: "Martin", lastName: "Fowler"};
export function defaultOwner() {
//BEFORE
function circum(radius) {
return circumference(radius);
}
//AFTER
function circum(radius) {
return circumference(radius);
}
//BEFORE
function circum(radius) {
return 2 * Math.PI * radius;
}
//AFTER
function circumference(radius) {
return 2 * Math.PI * radius;
}