discarded.txt

# CHANGES DISCARDED FROM CHANGELOG

Uncomment version patch field (BlockMen)
Typo fix in networkprotocol.h (Ner'zhul)
update README.txt (Ner'zhul)
Update Japanese Translation (Rui)
Use proper CMakeLists.txt for network and client directories (Loic Blot)
Move sha1.hpp and base64.hpp to util/ (Loic Blot)
Fix particles draworder (BlockMen)
Move hex.h to util/ (Loic Blot)
Add src/network/CMakeFiles/ and src/client/CMakeFiles to gitignore (4Evergreen4)
Wrap lines longer than 80 characters in lua_api.txt ...and minor formating changes (rubenwardy)
Revert "Fix particles draworder" (issue #2388) (Loic Blot)
Update minetest.po (Rui)
Add Turkish language (mahmutelmas06)
Add /setpassword and /clearpassword logging (est31)
Fix narrow_to_wide_c (ANDROID) (Craig Robbins)
Send Player HP when setHP (or a setHP caller) is called instead of looping and testing the state change. (Loic Blot)
Send Breath packet on event, don't check it at each AsyncRunStep (Loic Blot)
Remove unused m_wielded_item_not_sent (Loic Blot)
Send Inventory packet on event, don't check it at each AsyncRunStep. * Call UpdateCrafting into SendInventory because this functions is only called before SendInventory * Use Player* instead of peer_id for UpdateCrafting because SendInventory already has the Player* pointer, then don't loop for searching Player* per peer_id * m_env_mutex don't need to be used with this modification because it's already locked before the calls (Loic Blot)
ASyncRunStep doesn't need to lock when do setTimeOfDaySpeed. * setTimeOfDaySpeed already lock a mutex when modify the value, we don't need to lock all environment. * add a fine grain lock for getTimeOfDay and setTimeOfDay to solve environment multithread modifications on this value (Loic Blot)
Send Position packet on event, don't check it at each AsyncRunStep. * This permit to cleanup the player checking loop (Loic Blot)
We always know playerSAO when calling SendInventory. Using it instead of searching it via peer_id (Loic Blot)
ABMHandler and player_collisions use sequential read/write. Switch from std::list to std::vector * Also remove dead code Map::unloadUnusedData which is dead since a long time (Loic Blot)
Use std::vector instead of std::list in StaticObjectList and MutexedMap::getValues() (Loic Blot)
Remove Queue class which uses std::list and use native std::queue (Loic Blot)
Performance improvement: Use std::list instead of std::vector for request_media, Server::getModNames, Environment::m_simple_objects. * Also remove unused Server::m_modspaths (Loic Blot)
Server::AsyncRunStep: buffered_messages now uses std::vector instead of std::list. * sendRemoveNode and sendAddNodes are also converted as a side effect (Loic Blot)
Server.cpp Use std::list instead of std::vector for playSound, fillMediaCache, sendRequestedMedia, sendMediaAnnouncement and related functions (Loic Blot)
Replace std::list to std::vector into tile.cpp (m_texture_trash) and move tile.hpp to src/client/ (Loic Blot)
Fix issue #2441: crash on respawn, since a conversion std::list to std::vector on Environment.cpp * Also change some std::list to std::vector for ClientMap::renderMap * Remove disabled code in ClientMap::renderMap, disabled since a long time (Loic Blot)
Use std::queue for HTTPFetchRequest and std::vector for log_output instead of std::list (Loic Blot)
ProfilerGraph: Use std::list instead of std::vector (Loic Blot)
collisionMoveSimple: use std::vector instead of std::list, this improve the performances (Loic Blot)
l_get_modnames: Compare using std::sort instead of a custom function which does same work (Loic Blot)
Add more Android build files to .gitignore (est31)
Add Turkish comment translation to minetest.desktop (Mahmut Elmas)
Optimize Profiler::avg() (gregorycu)
Update Android Makefile (Maksim Gamarnik)
Silence Clang warning (ShadowNinja)
Unescape tooltip texts (est31)
Don't handle PlayerPos packet coming from client if player is dead (Loic Blot)
handleCommand_Breath mustn't update breath is player is dead. A dead player doesn't breath. Add Player::isDead function to check player is dead (Loic Blot)
Update Indonesian Language (SmallJoker)
Use the new Player::isDead function when it's the case (Loic Blot)
Rename some packet and handlers to <packet>_Legacy name for compat layer between new network changes and old network clients (Loic Blot)
Handle the newly added TOCLIENT_ACCESS_DENIED and TOCLIENT_DELETE_PARTICLESPAWNER * Rename the handlers from _Legacy to regular, because here we can use same handlers * Fix some packet names and pseudo handlers (Loic Blot)
Prepare Protocol v25 init & authentication. * TOSERVER_INIT and TOCLIENT_INIT renamed to _LEGACY * TOSERVER_PASSWORD merged from dev-0.5, can use protocol v24 and v25 * TOCLIENT_ACCESS_DENIED merged from dev-0.5, can use protocol v24 and v25, with normalized strings an a custom id for custom errors * new TOSERVER_INIT packet only send MT version, supported compressions, protocols and serialization, this permit to rework everything later without break the _INIT packet * new TOSERVER_AUTH packet which auth the client * new TOCLIENT_HELLO packet which send server serialization version atm * new TOCLIENT_AUTH_ACCEPTED which is send when TOCLIENT_AUTH was okay. After this packet, the client load datas from servers, like after TOCLIENT_INIT_LEGACY packet (Loic Blot)
Replace NetworkPacket pointers to references (Loic Blot)
client.cpp: typo fix and break; fix to make some compilers happy (Loic Blot)
AndroidManifest.xml version bump (Loic Blot)
Fix package name in AndroidManifest.xml (Loic Blot)
Android: fix package name in JAVA sources (Loic Blot)
Android: Backport changes from stable-0.4 (Loic Blot)
Android Makefile update backported from stable-0.4 with minor changes (Loic Blot)
SendPlayerHPOrDie everytime at client connection, damage enabled or not, this will fix the player which stay dead at connection (Loic Blot)
Rename packethandler/{client,server}.cpp to {client,server}packethandler.cpp * Requested by @Zeno- * Approved by @nerzhul (Loic Blot)
Move TOCLIENT_ACTIVE_OBJECT_REMOVE_ADD and TOCLIENT_ACTIVE_OBJECT_MESSAGES to private functions (Loic Blot)
Move client packet generators to dedicated functions for: * TOSERVER_INIT_LEGACY * TOSERVER_DELETEDBLOCKS * TOSERVER_GOTBLOCKS * TOSERVER_REMOVED_SOUNDS Also use a std::vector instead of std::set for TOSERVER_REMOVED_SOUNDS (Loic Blot)
Server::step throw is never catched. Replace it with an errorstream + assert This throw can be trigger by LuaError exception or ConnectionBindFailed exception in the following functions: * EmergeThread::Thread() * ScriptApiEnv::environment_Step() * ScriptApiEnv::player_event() * ServerThread::Thread() (Loic Blot)
Bump android version code (Loic Blot)
Revert "Server::step throw is never catched. Replace it with an errorstream + assert" (kwolekr)
Fix a little regression on SendActiveObjectMessages which send all TOCLIENT_ACTIVE_OBJECT_MESSAGES as reliable (Loic Blot)
Use the NetworkPacket api to read full version string instead of u8 pointers. Also store the reserved byte to use API properly (Loic Blot)
Server::step throw is never catched in minetestserver Replace it with an errorstream + assert for server (Loic Blot)
Standalone bundle for OSX (w/ dependencies!) (Pavel Puchkin)
Remove Android makefile ugly make -j hack (Loic Blot)
MutexedQueue inherits must use std::deque instead of std::list (Loic Blot)
ServerpacketHandler: spelling fixes (Loic Blot)
Add a Lua call to do damages / heals (Loic Blot)
Reset the old HP method on PlayerSAO::setHP (Loic Blot)
Revert "Fix issue #2441: crash on respawn, since a conversion std::list to std::vector on Environment.cpp" (kwolekr)
SendInventory when handleCommand_Interact is a use. This call was missing when change looping to triggering SendInventory: 1b2f64473ed4f222d3b7f02df853730d4382105e (poet-nohit)
Fix some loose ends from 3993093f (kwolekr)
Remove unused ConnectionCommand::sendToAll function. NetworkPacket::oldForgePacket returns Buffer instead of SharedBuffer and is used in ConnectionCommand instead of Connection::Send This remove the NetworkPacket buffer => SharedBuffer => Buffer copy. Now NetworkPacket => Buffer (Loic Blot)
Revert "Add a Lua call to do damages / heals" ok @ShadowNinja (Loic Blot)
Player: Fix a deadlock triggered by previous commit 0e5e49736c0a5fa29bca257bafc02d7c7a7171c9 (Loic Blot)
Fix cmake po detection bug (est31)
Fix Android build on 32 bit (est31)
Fix for sun/moon tonemaps: don't upscale 1px images. (Aaron Suen)
Mgv6: Use heightmap in placeTreesAndJungleGrass() (paramat)
Do not enable texture_clean_transparent by default (kwolekr)
Schematics: Error if unable to open file (kwolekr)
Fix endianness inconsistency with PcgRandom::bytes() (kwolekr)
Slow down the "key repeat" touch speed for some Android controls (Craig Robbins)
Don't send an InventoryAction at each setInventoryModified, we only need one SendInventory per inventory modification (Loic Blot)
Update timestamp to include date (Craig Robbins)
Update German translation and minetest.pot (Wuzzy)
Remove duplicate code since 8ca08a850ff2494652aa0ac2daa3d00f03aa4e7a (Loic Blot)
Clean up and tweak build system (ShadowNinja)
Fix typo in OpenGL ES 2 CMake file (ShadowNinja)
Document nil player as being allowed for can_dig (ShadowNinja)
Fix MSVC compile error (ShadowNinja)
Change error_message from wstring to string (ShadowNinja)
Fix GetText translation loading (ShadowNinja)
Make camera clear error message if there's no error (ShadowNinja)
Add Lua function get_video_modes() for main menu (Craig Robbins)
Update minetest.po (Rui)
Fix uninitialized variable Player::local_animation_speed (Loic Blot)
queued_commands must be a std::deque. RunCommandQueues needs to push packet on front, not back (Loic Blot)
Update credits (Craig Robbins)
Fix typo (Craig Robbins)
Make sure g_timegetter is initalised before running speedtests (Craig Robbins)
Fix Android build-related bugs (Craig Robbins)
Let main menu scale (non-Android) (Craig Robbins)
On Android enable always fast (Craig Robbins)
Use Buffer not SharedBuffer in NetworkPacket::oldForgePacket (Loic Blot)
GenElementManager: Pass opaque handles to Lua and rename to ObjDefManager (kwolekr)
Change format of screenshot names (Craig Robbins)
Move texture_min_size even further down the pipe. Now, textures are JIT-upscaled using an image transformation, right at the time they're added to a mesh or particle; images used in 2D elements are left unscaled. This should fix any remaining issues with HUD elements. (Aaron Suen)
Typo in getOutgoingSequenceNumber => successfull to successful (Loic Blot)
RunCommandQueues: little optimization remove command from queue on success, else do nothing, instead of remove command from queue and push it front on success (Loic Blot)
Connection::Receive(): receive Network Packet instead of SharedBuffer<u8>. Because we get a Buffer<u8> from ConnectionEvent, don't convert it to SharedBuffer<u8> and return it to Server/Client::Receive which will convert it to NetworkPacket Instead, put the Buffer<u8> directly to NetworkPacket and return it to packet processing This remove a long existing memory copy Also check the packet size directly into Connection::Receive instead of packet processing (Loic Blot)
Fix use of unitialized variable in gettext.cpp (Craig Robbins)
Fix some minor details from 6d61375 (kwolekr)
NetworkPacket: reading outside packet is now clearer. Use a common function to check the reading offset (Loic Blot)
Move globals from main.cpp to more sane locations (Craig Robbins)
Fix MSVC error caused by ed10005 (SmallJoker)
Create PacketError exception and use it with ACTIVEOBJECT_REMOVE_ADD handler which can be unreliable (Loic Blot)
craftdef.cpp: Return 0 after assert to make Clang happy (Loic Blot)
TOCLIENT_ACTIVE_OBJECT_REMOVE_ADD can be unreliable, catch PacketError exception. Also set the packet size at creation not when pushing rawString, no functional change (Loic Blot)
Change screenshot filename to one likely to work on all modern filesystems Fixes #2603 (Craig Robbins)
Make comments consistent with TOSERVER_INIT -> TOSERVER_INIT_LEGACY rename (est31)
Cavegen: Remove now unnecessary checks for water, lava, ice (paramat)
Fix missing SQLite3 statement pointer initialization (ShadowNinja)
TOCLIENT_ACTIVE_OBJECT_MESSAGES: channel must be 1 for unreliable message (Loic Blot)
Schematics: Prepend mod path to relative schematic filepaths (kwolekr)
Fix freetype detection (Dmitry Marakasov)
Link against shlwapi.lib and unify linker input sources for Windows (kwolekr)
Document for api functions that rely on current_modname, that it doesn't work when not loading mods (est31)
Add Spanish comment translation to minetest.desktop (ngosang)
Conf.example: Update, fix and improve mapgen flags docs (paramat)
Defaultsettings: Add dungeons and jungles flags. Update conf.example (paramat)
Use std::vector instead of std::set for Environment::getObjectsInsideRadius We are only iterating sequentially, we don't need a set here Also use a vector reference instead of a copy (Loic Blot)
Schematics: Refactor NodeResolver and add NodeResolveMethod (kwolekr)
Fix build for < C++11 since last commit (est31)
Fix path detection with --std= parameter (est31)
Biomes: Remove referenced biomes from Decorations on clear (kwolekr)
Refactor around translatePassword (est31)
Schematics: Remove referenced schematics from Decorations on clear (kwolekr)
Switch to check_v3s16 in l_mapgen.cpp and l_vmanip.cpp for type safety (kwolekr)
Fix build since: "Remove referenced schematics from Decorations on clear" (est31)
10s timeout when connecting to server (SmallJoker)
Porting: Refactor initalizePaths() (kwolekr)
Add 'persistence' alias for Lua noiseparams and validate more vector parameters (kwolekr)
Fix build on OS X (Thanks neoascetic) (kwolekr)
m_active_object_messages is used like a queue. Use std::queue instead of std::list. Also rename to m_active_object_messages_queue (Loic Blot)
Revert "m_active_object_messages is used like a queue. Use std::queue instead of std::list. Also rename to m_active_object_messages_queue" (kwolekr)
Only lowercase project name at compile time (ShadowNinja)
Fix crash on startup (Windows) (SmallJoker)
Re-apply 972d17baea81ffe6d508b291ef97207a4822e1da... but not rename the container. Approved-By est31 (nerzhul)
Protocol 25: wstring -> string for custom access denial reasons (est31)
DecoSchematic: Fix missing trees in rough terrain (paramat)
Remove unused variable Client::m_active_blocks (nerzhul)
German translation: shorter setting name (est31)
Remove fly mode in simple main menu (Muhammad Rifqi Priyo Susanto)
Update chinese translation (fishyWET)
Tests: Modularize unit testing (kwolekr)
Craftdef refactor (est31)
Remove craftdef serialisation (est31)
Update .gitignore (kwolekr)
Replace PRNG assertions with PrngException (kwolekr)
Revert "Only lowercase project name at compile time" (sfan5)
Revert the upper-case PROJECT_NAME nonsense that was part of #2402 (sfan5)
Add Russian comment translation to minetest.desktop (mich1)
Tests: Add random unittests (kwolekr)
Fix MSVC compatibility (kwolekr)
Fix several MSVC issues numeric.h (SmallJoker)
Add .patch files to gitignore (est31)
Better version detection for shallow clones (est31)
ObjDefManager: Set replacement object's handle info after calling set() (kwolekr)
Tests: Add ObjDef unittests (kwolekr)
Cache enable_3d_clouds flag (est31)
Update Turkish Language (Mahmut Elmas)
Fix GCC compiler warning (ShadowNinja)
Make Git version detection use VERSION_STRING instead of tags (ShadowNinja)
Tests: Add NodeResolver unittests (kwolekr)
NodeDefManager: Improve const-correctness of interfaces (kwolekr)
Fix build on Debian broken by b45df9d (missing include, somehow?) (kwolekr)
Improve Redis error messages (ShadowNinja)
Fix error messages for type-checking Lua reading functions (ShadowNinja)
Fix connection speed unit names (ShadowNinja)
NodeResolver: Remove NodeResolveMethod (kwolekr)
Schematics: Add indent-with-space option for schematic Lua table serialization (kwolekr)
Remove duplicate lua_getfield() in c_converter.cpp (Kevin Ott)
Conf.example: Update recommended maximum cloud radius to 26 (paramat)
Fix missing Y component assignment in check_v3f (kwolekr)
Gracefully handle PacketErrors (est31)
Tests: Add schematic unittests (kwolekr)
Fix compilation for non-client builds, and fix signed comparison warning (kwolekr)
Fix release build warning (est31)
Replaced libjpeg dependency on apt-get, it should be libjpeg-dev instead of libjpeg8-dev. (Megaf)
Add LibGMP (est31)
Make early protocol auth mechanism generic, and add SRP (est31)
Build and link gmp correctly on MSVC (SmallJoker)
Fix compiler warning about sign comparison (est31)
Item entity merging refactor (est31)
Fix libgmp for Android (est31)
Generalize core.get/set_nametag_color into core.get/set_nametag_attributes (TeTpaAka)
Add push_ARGB8 to script/common/c_converter (TeTpaAka)
Finalize init packets and enable protocol v25 (est31)
Fix build since last commit (est31)
Add -Wsign-compare for Clang builds and fix some signed/unsigned compiler warnings (kwolekr)
Add optional buffer param for bulk data array writes in Lua (kwolekr)
Record MapBlock modification reasons as flags instead of strings (kwolekr)
Fix null dereference when loading schematic from definition without a NodeDefManager (kwolekr)
Add more swp files to gitignore (est31)
Enforce hiding nametag (est31)
Lower log level for unexpected behaviour (est31)
Split ObjDef/ObjDefManager out to objdef.cpp (kwolekr)
Fix build with libstdc++ (kwolekr)
Replace instances of std::map<std::string, std::string> with StringMap (kwolekr)
Fix documentation for texture override face selector behaviour (est31)
Don't ignore nametag attribute change message for newer versions (est31)
Deny empty username early in the protocol (est31)
Fix Windows build, clean up included headers (SmallJoker)
Small clientiface ASCII art improvements (est31)
Spare some string copies (est31)
Consistent const string params (est31)
Fix typo in variable name (Kahrl)
Make get_biome_list() error message more helpful (kwolekr)
Only retrieve always_fly_fast setting once (SmallJoker)
Mapblock: nodecount refactor (est31)
Make split method static (est31)
Localize inside whole misc_helpers.lua (est31)
Fix wrong replace from previous commit (est31)
Nicer time setting logging (est31)
Fix uninitialized variable error (est31)
Reposition irrlicht timestamp in makefile (est31)
Add utf-8 conversion utilities and re-add intlGUIEditBox (est31)
Android: bypass broken wide_to_utf8 with wide_to_narrow (est31)
Add UTF and other utility unit tests (est31)
Automated whitespace error fix for last commit (est31)
Remove reference to deprecated privilege (Craig Davison)
Ignore punches with no damage in the actionstream (SmallJoker)
Don't highlight entries in credits (Wuzzy)
Update credits tab (est31)
GUIFormSpecMenu::OnEvent code style update and small refactor (est31)
Simpler patch for saplings trying to grow on unknown nodes (ShadowNinja)
Fail iconv call gracefully (est31)
Make wrap_rows not wrap inside utf-8 multibyte sequences (est31)
Don't print an error for valid listring[] formspec (est31)
Fix wrap_rows at inner byte of multibyte sequence (figec)
Generic CAO cleanups and renames for clarification (est31)
More correct wrap_rows implementation (figec)
Small CAO improvements (est31)
Android: use loop inside makefile to spare repetition (est31)
Update Chinese translation (Zheyu Shen)
Use actionstream instead of errorstream when failing to emerge player (Craig Davison)
Add MoveSomewhere inventory action (est31)
Small TOCLIENT_HELLO logging fix (est31)
Typo fix on previous @est31 commit (Loic Blot)
Use frame instead of words 'no screenshot available' (rubenwardy)
Return to ignore (est31)
Remove compile warning (est31)
Remove busy polling inside minimap thread (est31)
Minimap update (RealBadAngel)
Bugfix: minimap was updated only with loading new blocks, allow forced updates with changing player pos (RealBadAngel)
Bugfix: variable type mismatch (RealBadAngel)
Fix *BSD build with GNU iconv (kwolekr)
Add UpdateThread and use it for minimap and mesh threads (est31)
Defer minimap update when shape changed (est31)
Make m_blocks_cache private (est31)
Add android tools environment to gitignore (est31)
Inventory manager style cleanup and further checks (est31)
Fix world.mt not written when selecting mode (Sokomine)
Fix code style from recent commits and add misc. optimizations (kwolekr)
Client: better m_proto_ver initialisation (est31)
Clean-up Minimap code (kwolekr)
Use UTF-8 instead of narrow (est31)
Windows: Fix some warnings. (Diego Martinez)
Update clouds enable_3d_clouds when setting changed (est31)
Settings: pass name to callbacks by reference (est31)
Little coding style fix on porting.h (Loic Blot)
Misc. minor fixes (kwolekr)
Mgv6/treegen: (Re)Add fallback nodes for compatibility with subgames (paramat)
Minimal: Remove recently added unnecessary nodes (paramat)
Remove raw message output on AOM deserialization failure (kwolekr)
Increase limit of serialized long strings (kwolekr)
connection.cpp: remove unused constructor (Loic Blot)
Make serialization error message translatable (Kahrl)
Server kicks: make messages configurable, cache wstring (est31)
Translated using Weblate (Italian) (Michal Čihař)
Translated using Weblate (French) (Jean-Patrick G)
Translated using Weblate (Japanese) (Tae Lim Kook)
Translated using Weblate (Korean) (Tae Lim Kook)
Translated using Weblate (Japanese) (sfan5)
Translated using Weblate (Japanese) (Rui)
Translated using Weblate (Turkish) (Michal Čihař)
Run updatepo.sh (est31)
Fix invisible player when the attached entity is removed (TeTpaAka)
Fix a typo in comment of CMakeLists.txt (D Laboratory)
Update toolchain_mingw64.cmake (Rui)
Clarify docs for auth.cpp method (est31)
Fix crash in mainmenu when loaded subgame does not have a "menu" directory (sfan5)
Add note that chat messages can be marked as handled. (Robert Zenz)
Fix issues with light of attached CAOs (RealBadAngel)
Update my name (Novatux)
Bump protocol to 26 (est31)
Remove some old dead code. Fix some Clang warnings in SRP (ng->N... will always evaluate to true. (Loic Blot)
Check output of mpz_set_str and fix leak on error condition (est31)
Extend CMake variable descriptions (SmallJoker)
Android: fix horrible libiconv build (est31)
Small SendableMediaAnnouncement cleanup (Loic Blot)
Fix 0.4.11 githash for android (est31)
Android: speed up rebuild, and prevent race condition fail (est31)
Dungeon generation: Fix code style issues in dungeongen.cpp (paramat)
tests: Log exceptions thrown inside of unit tests (kwolekr)
Clean up util/serialization.{cpp,h} and add unit tests (kwolekr)
Translated using Weblate (French) (Jean-Patrick G)
Translated using Weblate (German) (est31)
Translated using Weblate (Japanese) (Rui)
Translated using Weblate (French) (Jean-Patrick G)
Translated using Weblate (German) (est31)
Translated using Weblate (Japanese) (Rui)
Translated using Weblate (German) (Jackie Coe)
Translated using Weblate (German) (Jackie Coe)
Translated using Weblate (German) (est31)
Translated using Weblate (Russian) (Andrey K)
Translated using Weblate (Hungarian) (Kisbenedek Márton)
Remove unused file (Loic Blot)
Update Spanish translation. (Diego Martinez)
Translated using Weblate (German) (sfan5)
Don't do formspec escaping twice for loading description (est31)
Remove unused function from connection.{cpp,h} (nerzhul)
Defaultsettings: Increase client_mapblock_limit to 5000 (paramat)
Remove unused functions. (onkrot)
SEnv: Remove static_exists from ActiveObjects in deleted blocks (kwolekr)
Android: bypass broken wide_to_utf8 with wide_to_narrow (again) (est31)
Add Japanese translation of desktop file (Rui)