Skip to content

Instantly share code, notes, and snippets.

@ryantm

ryantm/rfc30.md

Last active September 11, 2018 16:09
Show Gist options
  • Star 0 You must be signed in to star a gist
  • Fork 0 You must be signed in to fork a gist
  • Save ryantm/44431aba6b15519cdcccd191525bd0ac to your computer and use it in GitHub Desktop.
Save ryantm/44431aba6b15519cdcccd191525bd0ac to your computer and use it in GitHub Desktop.
Download ZIP
Raw
rfc30.md

nixpkgs PR review workflows

PR needs review

  1. Visit https://github.com/NixOS/nixpkgs/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+review%3Anone+sort%3Acreated-asc+-label%3A%222.status%3A+work-in-progress%22+-label%3A%222.status%3A+merge+conflict%22 and work from oldest PR to newest PR. (First come, first served.)

  2. If the PR is a work in progress and does not have label "2.status: work-in-progress" either add this label, or if you do not have permission, add a "Request changes" review with a "Review Summary" of "PR triage: work-in-progress". Move on to the next PR.

  3. If the PR currently does not merge and does not have label "2.status: merge-conflict" either add this label, or if you do not have permission to, add a "Request changes" review with a "Review Summary" of "PR triage: merge-conflict". Move on to the next PR.

  4. If the last activity on the PR is a comment that is not from the pull requester, and you agree with their comments, add a "Request changes" review with a "Review Summary" of "PR triage: please address issues rasied by commenters". Move on to the next PR.

  5. If @GrahamCOfBorg has an unexpected build failure on the PR, add a "Request changes" review with a "Review Summary" of "PR triage: please fix OfBorg build". Move on to the next PR.

  6. If you feel that you are capable of code review, do a normal GitHub code review. If you suggest any changes at all, choose "Request changes". If looks good to you, choose "Approve". If you can, tell @GrahamCOfBorg to build the PR. Move on to the next PR.

  7. If you feel you cannot process this PR, move on to the next PR. Someone else will process it later.

PR needs second review

  1. Visit https://github.com/NixOS/nixpkgs/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aopen+review%3Aapproved+sort%3Acreated-asc+-label%3A%222.status%3A+work-in-progress%22+-label%3A%222.status%3A+merge+conflict%22+ and work from oldest PR to newest PR. (First come, first served.)

  2. If @GrahamCOfBorg has not built this PR, ask it to. Revist after it has built.

  3. If it also looks good to you and doesn't seem major enough to warrant more discussion, merge it.

Following up on PRs you approved

  1. Visit https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+is%3Aopen+%22init+at%22+-label%3A%222.status%3A+work-in-progress%22+-label%3A%222.status%3A+merge+conflict%22+reviewed-by%3Aryantm+review%3Aapproved+sort%3Acreated-asc and work from oldest PR to newest PR. (First come, first served.)

  2. If there are no changes, @GrahamCOfBorg has built it, and it has been at least three days, merge it.

Following up on PRs you requested changes on

  1. Visit https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+is%3Aopen+%22init+at%22+-label%3A%222.status%3A+work-in-progress%22+-label%3A%222.status%3A+merge+conflict%22+reviewed-by%3Aryantm+review%3Achanges-requested+sort%3Aupdated-asc and work on the least recently updated PR first.

  2. If there has been no updates since you first reviewed the PR, and 30 days have elapsed, close the PR with comment "PR triage: closing this PR because there has been no resposne to requsted changes in 30 days. We can open it later, if you ask us to.", or if you do not have permission, add a comment asking for it be closed: "PR triage: please close this PR because there has been no response to requested changes in 30 days."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment