Skip to content

Instantly share code, notes, and snippets.

@ryubro
Created July 24, 2017 07:41
Show Gist options
  • Save ryubro/1fe56447a88d2a04758a1784351aa3c4 to your computer and use it in GitHub Desktop.
Save ryubro/1fe56447a88d2a04758a1784351aa3c4 to your computer and use it in GitHub Desktop.

While I was giving feedback to the REST API design of our CMS, I felt like this is a more general issue than a specific case, because I felt the same when I saw how the tasks work in Iris.

I like the general concept of Iris. I cannot agree more about the idea that we should separate the coaching logic and the app logic. But I have to say that some parts of Iris are implemented in poor ways.

Let me be more specific. Our CMS REST API is using POST method for the querying contents. You'll know that we should use GET if you finished the REST API design 101. The way the tasks work is so restricted without any good reason that it couldn't support the Brightr shift properly. I can tell that this is done by who doesn't understand JS.

Excuse me for saying that Umar is not very good at REST API and JS, but that's not a shame at all. Everyone has his own strength. Even Ricky the Everything doesn't know as much as Dwi the Jr. Developer when it comes to JS (CRMIIW, no research is done). Now it looks like that every part of Iris is designed by Umar but I think we need to let experts to design on each realm of Iris.

I have an impression that no developers are comfortable to improve the design of a part of the Iris because they don't know the rest. But this is a problem that we need to solve. Well-designed system should let the engineer to design a specific part withtout knowing every part of the system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment