Skip to content

Instantly share code, notes, and snippets.

@s1monw
Created December 5, 2014 08:39
Show Gist options
  • Save s1monw/94962a543481cdd2fd51 to your computer and use it in GitHub Desktop.
Save s1monw/94962a543481cdd2fd51 to your computer and use it in GitHub Desktop.
Fixed Issues / Open Pull Requests
=================================
Not much to do here except for twiddling thumbs and maybe poking people
to review / merge those. Those are basically "fixed" issues.
8652, 5668 (BUG), 8742 (pull; mine)
starter script ignores errors when running Elasticsearch in background
AND
Invalid values in elasticsearch.yml causes start to silently fail
----------------------------------------------------------------------
* https://github.com/elasticsearch/elasticsearch/issues/8652
* https://github.com/elasticsearch/elasticsearch/issues/5668
* Fixed by pull request 8742
"background start-up: use PID file to signal success"
* Pull request needs review, can be merged w/o conflicts
8419 (BUG), 8732 (pull; mine)
The elasticsearch user's home directory belongs to root for RPM installs
----------------------------------------------------------------------
* https://github.com/elasticsearch/elasticsearch/issues/8419
* Fixed by pull request 8732
"rpm,deb: make ES user own plugins dir, remove on uninstall"
* Pull request needs review, can be merged w/o conflicts, and is
wrongly labelled "Awaiting CLA"
8625 (enhancement), 7598 (pull, by tom prince)
Make dependency on `which` in the binary package
------------------------------------------------
* https://github.com/elasticsearch/elasticsearch/issues/8625
* Fixed by pull request 7598
"Add dependencies to generated RPM"
* Pull request open since Sep 4th
* adds "which" and "jre >= 1.7" package dependencies,
both are correct imho (also see "Feedback required" below)
* Pull req. is for ES 1.3, but can easily merged into master, too
6909 (pull by "sbraz")
Prevent init script from returning when the service isn't actually started
------------------------------------------------
* https://github.com/elasticsearch/elasticsearch/issues/6909
* Idle since Oct 21
* Incorrectly labelled "feedback needed"
("sbraz" gave feedback on Oct 21)
5317 (pull by spinscale), 4429 (pull by recastrodiaz)
Packaging: Log stdout output into file,
Log JVM stdout on service start
------------------------------------------------
* https://github.com/elasticsearch/elasticsearch/issues/5317
* https://github.com/elasticsearch/elasticsearch/issues/4429
* Those two pull requests do the same thing in the same file
* both are idle since Jul 18
* 5317 could be merged w/o conflicts, 4429 has conflicts
5770, 7078 (pull request by spinscale, MERGED)
ES 1.0.2 debian package fails on removing dirs when purged
----------------------------------------------------------
* https://github.com/elasticsearch/elasticsearch/issues/5770
* Was addressed in PR 7078 which has been merged on Sep 18
* So this issue was probably fixed?
6131 (pull by "KlavsKlavsen")
Making rpm update init.d script even if its been locally changed
------------------------------------------------
* https://github.com/elasticsearch/elasticsearch/pull/6131
* open since May 12, last feedback from author May 19
* Idle since Oct 20
* needs review
3973 (pull by spinscale)
Add ES_STOP_TIMEOUT configuration variable to packages
--------------------------------------------------------
* https://github.com/elasticsearch/elasticsearch/issues/3973
* open since Oct 25, 2013(!)
* idle since Sep 25
* Needs decision whether ES should be killed at all after timeout
3162 (pull by "vieux")
add Dockerfile to easily build elasticsearch into a runnable linux container
--------------------------------------------------------
* https://github.com/elasticsearch/elasticsearch/issues/3162
* open since Jun 11, 2013(!)
* idle since Sep 6
* Doesn't interfere with anything ES, just adds a Docker config
file to the source tree
8600 (documentation, pull req. by "tristanbob")
Added a command to start elasticsearch on bootup
------------------------------------------------
* https://github.com/elasticsearch/elasticsearch/issues/8600
* Title is slightly misleading: _documentation_ for a
command was added
* looks good to me
8471 (BUG), 8479 (pull by "ankon")
Non-existing location for default gc.log file
(This is a Windows batch file bug/improvement)
---------------------------------------------
* https://github.com/elasticsearch/elasticsearch/issues/8471
* Fixed by pull request 8479
"Allow configuration of the GC log file via an environment
variable"
7670 (pull by "chipitsine")
nice try to detect JAVA_HOME
(This is a Windows batch file bug/improvement)
---------------------------------------------
* https://github.com/elasticsearch/elasticsearch/pull/7670
* Pull request opened Sep 10, idle since Sep 18
* has merge conflicts, needs review
6533 (pull by "winpat"; obsolete)
Added SLES11 Support to Initscript
----------------------------------
* https://github.com/elasticsearch/elasticsearch/pull/6533
* 23 days ago the author ("winpat") stated that this PR is obsolete
(last comment in the issue)
ES Discussion / Decision needed
============================
Issues which need discussion / a non-technical decision from
Elasticsearch devs.
6087
Docs suggest downloading GPG key over HTTP
-----------------------------------------
* https://github.com/elasticsearch/elasticsearch/issues/6087
* Issue has a few +1es in the comments
* Easy fix IF you have access to the ES public key and GIT repo
==> Someone inside ES needs to publish the public key to the github
repo, then the documentation can be updated accordingly.
2794
Downloads have incomplete notices and license texts
-----------------------------------------
* https://github.com/elasticsearch/elasticsearch/issues/2794
* open/idle since March 18, 2013(!)
==> Pull request was offered in the comments, but no response
==> ES internal developer w/ insight of the libraries used in ES needs
to add the licenses
5408
deb created on Windows doesn't install
-----------------------------------------
* https://github.com/elasticsearch/elasticsearch/issues/5408
* last comment in issue (by spinscale) on Jul 18 suggests "won't
fix"
* Looks like a "won't fix" to me?
==> Close as "won't fix?"
2172
upstart script
-----------------------------------------
* https://github.com/elasticsearch/elasticsearch/issues/2172
* Open since Aug 2012(!)
* Last comment by spinscale on Jul 18 2014 suggests this issue is
obsolete
==> Close as "won't fix?"
8625 (Discussion), 7598 (PR by tom prince)
Make dependency on `which` in the binary package /
Add dependencies to generated RPM
-----------------------------------------
* Discussion:
https://github.com/elasticsearch/elasticsearch/issues/8625
* User "grepwood" seems worried about the JRE dependency
* imho dep is correct; users whoc don't want dependency management
would not install the RPM but the TGZ
==> Should the RPM depend on a JRE?
4978
sysctl: permission denied on key 'vm.max_map_count' - OpenVZ
Elasticsearch 0.90.9 compatibility issue
-----------------------------------------
* https://github.com/elasticsearch/elasticsearch/issues/4978
==> Should OpenVZ be detected automatically and MAX_MAP_COUNT in
/etc/default/elasticsearch adjusted correspondingly?
8493
Lack of systemd init files in deb package
-----------------------------------------
* https://github.com/elasticsearch/elasticsearch/issues/8493
* systemd is not yet included in current Debian releases (7.8) but
will be available in the upcoming release
* Debian 8 "Jessie" was feature-frozen recently and is currently in
"testing" state. Will be released in 2015
==> Does Elasticsearch .deb support testing/upcoming releases?
7383
Request: expand JAVA_HOME search paths for Debian/Ubuntu
--------------------------------------------------------
* https://github.com/elasticsearch/elasticsearch/issues/7383
* opened 21st of August, idle since 2nd of October
==> Should $JAVA_HOME be auto-detected the way "Reiner030" suggests, or
statically configured (as Uwe Schindler remarks)?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment