Create a gist now

Instantly share code, notes, and snippets.

What would you like to do?
How github PRs should work
Unfortunately, they don't support our work flow... rebase and make a merge commit. sigh. the problem is they are
fighting and fighting from adding a couple of checkboxes and trying to just name workflows. squashing, rebasing,
and merge vs fast-forward are independent decisions, there are more possibilities than this weird UI can possibly
reflect.
When I'm github PM, I will make them do two settings for the repo:
- allow unrebased=yes/no (default yes)
- use-merge-commit=yes/no (default yes)
And then the PR merge button will have only two possibilities: squash=yes/no (default no)
This would cover all useful possibilities, and be much simpler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment