Skip to content

Instantly share code, notes, and snippets.

@sambacha
Last active August 6, 2021 07:13
Show Gist options
  • Save sambacha/647069b2cc4d39d3d650d29c16d9008b to your computer and use it in GitHub Desktop.
Save sambacha/647069b2cc4d39d3d650d29c16d9008b to your computer and use it in GitHub Desktop.

MetaMask changes for v10

Builds ready [aa0f35a]

Page Load Metrics (688 ± 45 ms)

Censorship and Anti-Privacy / Tracking related

Infura INFURA_BLOCKED_KEY

https://github.com/MetaMask/metamask-extension/blob/594025a198b285e39dc3204f2094e492da333e1e/shared/constants/network.js#L127

MetaMask/metamask-extension#11363

Metric events for Approved, Rejected, and Submitted to the TxController

https://github.com/MetaMask/metamask-extension/pull/11731/commits/4ba565e7196635caf63d803cab830e03bab85684

Added more tracking events of user behavior

MetaMask/metamask-extension#11352

Wyre’s API via our backend to generate Wyre’s Checkout URL

https://github.com/MetaMask/metamask-extension/pull/11731/commits/a1d7271ed7f43d1f89eabfa04d83d903a75dae3d

// source: https://github.com/MetaMask/metamask-extension/blob/714170c7b8a4b182b511d3fd5157ddcf5f381178/shared/constants/swaps.js#L101
const METASWAP_ETH_API_HOST = 'https://api.metaswap.codefi.network';

export const METASWAP_CHAINID_API_HOST_MAP = {
  [MAINNET_CHAIN_ID]: METASWAP_ETH_API_HOST]
  };

Notable changes not related to privacy / extracting user value

New UI Components for EIP1559

MetaMask/metamask-extension#11357

Send MAX amount button enabled

MetaMask/metamask-extension#11322

disable sending of ERC-721's

https://github.com/MetaMask/metamask-extension/pull/11731/commits/e10ddbe3a347f08d5a60d5ec307e70f29b2ef7c8#diff-1d625f930146dc85f8aec58a562a272ebabfc0a72451a9b3a702c9b008c771d0R18

/*
 *  bytes4(keccak256('name()')) == 0x06fdde03
 *  bytes4(keccak256('symbol()')) == 0x95d89b41
 *  bytes4(keccak256('tokenURI(uint256)')) == 0xc87b56dd
 *
 *  => 0x06fdde03 ^ 0x95d89b41 ^ 0xc87b56dd == 0x5b5e139f
 */

bytes4 private constant _INTERFACE_ID_ERC721_METADATA = 0x5b5e139f;

constructor (string memory name, string memory symbol) public {
  _name = name;
  _symbol = symbol;

  // register the supported interfaces to conform to ERC721 via ERC165
  _registerInterface(_INTERFACE_ID_ERC721_METADATA);
}

Origination source PR

MetaMask/metamask-extension#11731

Diff of the Changelog, notice any mention of 'metrics' is not included

( granted this is not published yet ) https://github.com/MetaMask/metamask-extension/commit/d0e4a890c48859a3d8ae5f48257da1004039e7a3.diff

@jambestwick
Copy link

congratulations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment