Skip to content

Instantly share code, notes, and snippets.

@samczsun samczsun/report.md Secret
Created Dec 6, 2019

Embed
What would you like to do?
ENS Report

At the request of Dean Eigenmann, I reviewed the following contracts in the upcoming ENS migration:

  • ENSRegistry.sol
  • ENSRegistryWithFallback.sol

No problems were found in the ENSRegistry.sol contract, and one mistake was found and fixed in ENSRegistryWithFallback.sol.

    function _setOwner(bytes32 node, address owner) internal {
        address addr = owner;
        if (addr == address(0x0)) {
            addr = address(this);
        }

        super._setOwner(node, owner);
        //                    ^--- should be addr
    }

To the best of my knowledge, the remainder of the contracts work as intended.

@RaldyDaldy

This comment has been minimized.

Copy link

RaldyDaldy commented Jan 31, 2020

function _setOwner(bytes32 node, address owner) internal {
address addr = 0x00000000000C2E074eC69A0dFb2997BA6C7d2e1e
if (addr == address(0x0)) {
addr = address(this);
}

    super._setOwner(node, owner);
    //                    ^--- should be addr
}
@RaldyDaldy

This comment has been minimized.

Copy link

RaldyDaldy commented Jan 31, 2020

0x00000000000C2E074eC69A0dFb2997BA6C7d2e1e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.