Skip to content

Instantly share code, notes, and snippets.

@samczsun
Created Dec 6, 2019
Embed
What would you like to do?
ENS Report

At the request of Dean Eigenmann, I reviewed the following contracts in the upcoming ENS migration:

  • ENSRegistry.sol
  • ENSRegistryWithFallback.sol

No problems were found in the ENSRegistry.sol contract, and one mistake was found and fixed in ENSRegistryWithFallback.sol.

    function _setOwner(bytes32 node, address owner) internal {
        address addr = owner;
        if (addr == address(0x0)) {
            addr = address(this);
        }

        super._setOwner(node, owner);
        //                    ^--- should be addr
    }

To the best of my knowledge, the remainder of the contracts work as intended.

@DavNaty
Copy link

DavNaty commented Mar 12, 2022

0x57f1887a8BF19b14fC0dF6Fd9B2acc9Af147eA85 david2778h.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment