Skip to content

Instantly share code, notes, and snippets.

@samczsun
Created December 6, 2019 04:37
Show Gist options
  • Star 11 You must be signed in to star a gist
  • Fork 4 You must be signed in to fork a gist
  • Save samczsun/2f0a2e266191042baada48c5407d8986 to your computer and use it in GitHub Desktop.
Save samczsun/2f0a2e266191042baada48c5407d8986 to your computer and use it in GitHub Desktop.
ENS Report

At the request of Dean Eigenmann, I reviewed the following contracts in the upcoming ENS migration:

  • ENSRegistry.sol
  • ENSRegistryWithFallback.sol

No problems were found in the ENSRegistry.sol contract, and one mistake was found and fixed in ENSRegistryWithFallback.sol.

    function _setOwner(bytes32 node, address owner) internal {
        address addr = owner;
        if (addr == address(0x0)) {
            addr = address(this);
        }

        super._setOwner(node, owner);
        //                    ^--- should be addr
    }

To the best of my knowledge, the remainder of the contracts work as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment