gistfile1.txt

Before:

● ~/flocker (master)$ sudo mount | grep bind
/home/ubuntu/flocker/_trial_temp/flocker.node.agents.test.test_bl/BlockDeviceManagerTests/test_bind_mount/tmpk5d9T1/temp/0386b1ff-34ef-41ef-bb24-d0bfa04c048e on /home/ubuntu/flocker/_trial_temp/flocker.node.agents.test.test_bl/BlockDeviceManagerTests/test_bind_mount/tmpk5d9T1/temp/ecf14368-2697-44d1-baba-a0d785ecc45f type none (rw,bind)
● ~/flocker (master)$ sudo `which trial` -e flocker.node.agents.test.test_blockdevice_manager
could not remove FilePath('/home/ubuntu/flocker/_trial_temp'), caught OSError [Errno 16]: Device or resource busy
flocker.node.agents.test.test_blockdevice_manager
  BlockDeviceManagerTests
    test_bind_mount ...                                                    [OK]
    test_failing_bind_mount ...                                            [OK]
    test_formatted_bad_type ...                                            [OK]
    test_get_mounts_shows_only_mounted ...                                 [OK]
    test_implements_interface ...                                          [OK]
    test_make_tmpfs_mount ...                                              [OK]
    test_make_tmpfs_mount_failure ...                                      [OK]
    test_mount_multiple_blockdevices ...                                   [OK]
    test_mount_multiple_times ...                                          [OK]
    test_mount_unformatted ...                                             [OK]
    test_remount ...                                                       [OK]
    test_remount_failure ...                                               [OK]
    test_unmount_unmounted ...                                             [OK]

-------------------------------------------------------------------------------
Ran 13 tests in 7.644s

PASSED (successes=13)
● ~/flocker (master)$ sudo mount | grep bind
/home/ubuntu/flocker/_trial_temp/flocker.node.agents.test.test_bl/BlockDeviceManagerTests/test_bind_mount/tmpk5d9T1/temp/0386b1ff-34ef-41ef-bb24-d0bfa04c048e on /home/ubuntu/flocker/_trial_temp/flocker.node.agents.test.test_bl/BlockDeviceManagerTests/test_bind_mount/tmpk5d9T1/temp/ecf14368-2697-44d1-baba-a0d785ecc45f type none (rw,bind)
/home/ubuntu/flocker/_trial_temp/flocker.node.agents.test.test_bl/BlockDeviceManagerTests/test_bind_mount/tmp599Kjj/temp/976f6a64-4bea-43fb-a2ea-20408d79f098 on /home/ubuntu/flocker/_trial_temp/flocker.node.agents.test.test_bl/BlockDeviceManagerTests/test_bind_mount/tmp599Kjj/temp/cf058b7c-792a-49f0-a191-21ac5c08167d type none (rw,bind)

^^ 1 more after running test


After:

● ~/flocker (master)$ git checkout fix-missing-cleanup-FLOC-3893 
Branch fix-missing-cleanup-FLOC-3893 set up to track remote branch fix-missing-cleanup-FLOC-3893 from origin.
Switched to a new branch 'fix-missing-cleanup-FLOC-3893'
● ~/flocker (fix-missing-cleanup-FLOC-3893)$ sudo `which trial` -e flocker.node.agents.test.test_blockdevice_manager
could not remove FilePath('/home/ubuntu/flocker/_trial_temp'), caught OSError [Errno 16]: Device or resource busy
flocker.node.agents.test.test_blockdevice_manager
  BlockDeviceManagerTests
    test_bind_mount ...                                                    [OK]
    test_failing_bind_mount ...                                            [OK]
    test_formatted_bad_type ...                                            [OK]
    test_get_mounts_shows_only_mounted ...                                 [OK]
    test_implements_interface ...                                          [OK]
    test_make_tmpfs_mount ...                                              [OK]
    test_make_tmpfs_mount_failure ...                                      [OK]
    test_mount_multiple_blockdevices ...                                   [OK]
    test_mount_multiple_times ...                                          [OK]
    test_mount_unformatted ...                                             [OK]
    test_remount ...                                                       [OK]
    test_remount_failure ...                                               [OK]
    test_unmount_unmounted ...                                             [OK]

-------------------------------------------------------------------------------
Ran 13 tests in 7.663s

PASSED (successes=13)
● ~/flocker (fix-missing-cleanup-FLOC-3893)$ sudo mount | grep bind
/home/ubuntu/flocker/_trial_temp/flocker.node.agents.test.test_bl/BlockDeviceManagerTests/test_bind_mount/tmpk5d9T1/temp/0386b1ff-34ef-41ef-bb24-d0bfa04c048e on /home/ubuntu/flocker/_trial_temp/flocker.node.agents.test.test_bl/BlockDeviceManagerTests/test_bind_mount/tmpk5d9T1/temp/ecf14368-2697-44d1-baba-a0d785ecc45f type none (rw,bind)
/home/ubuntu/flocker/_trial_temp/flocker.node.agents.test.test_bl/BlockDeviceManagerTests/test_bind_mount/tmp599Kjj/temp/976f6a64-4bea-43fb-a2ea-20408d79f098 on /home/ubuntu/flocker/_trial_temp/flocker.node.agents.test.test_bl/BlockDeviceManagerTests/test_bind_mount/tmp599Kjj/temp/cf058b7c-792a-49f0-a191-21ac5c08167d type none (rw,bind)
● ~/flocker (fix-missing-cleanup-FLOC-3893)$

^^ 0 more after running test