source_filtering_kibana.md

elastic/kibana#5981

• meta fields support ?
• @Bargs: I think it should not, since excluding a field is only for preventing huge fields to be loaded
• documentation. Mention where the filtering happens, e.g., in the search table
• test for filtering
• in the dashboard
• in discover
• when adding a visualization
  • @Bargs: it is possible to create, e.g., a data table, with a term agg on an excluded field. OK ?
• remove disable filter bar from the Field filters tab in the Settings page
• typos
• filter scripted fields ?
• @Bargs: I think this should not be possible
• sync field filters and field exclusion in control
• @Bargs: should the exclusion checkbox in the field controls be removed ? ATM it doesn't work together with the "field filters". I think it is OK to remove it since the wildcard field filters are probably enough, and we can see the list of excluded fields too. See http://imgur.com/a/cZLgw

• Agree on meta field support being unnecessary, but then we should probably not allow them to be added to the list in the first place.
• Same for scripted fields, I'm ok with not allowing them but then they shouldn't show up as options in the list of options as the user begins to type.
• An additional thought on documentation: we're trying to add as little external documentation as possible these days, so if this can be solved with more clear in page documentation that would be best.

it is possible to create, e.g., a data table, with a term agg on an excluded field. OK ?

Seems ok if the primary goal of the feature is to prevent automatically loading too much data in Discover. As long as we clearly describe where the filter is expected to work. If the filter doesn't work for visualizations though, how does filtering work on dashboards? Does it just filter saved searches?

should the exclusion checkbox in the field controls be removed ?

It seems like that checkbox was added with this PR as well? I'm ok with removing it. Having multiple ways to filter a field would be confusing anyway, especially if the filter list isn't updated correctly.

If the filter doesn't work for visualizations though, how does filtering work on dashboards? Does it just filter saved searches?

Yes, you are correct. I tested that when I create a visualization based on a saved search, I have the following:

• excluded fields are not available (not in the JSON nor the Table view for a document)
• if the visualization was created before excluding a field, you would see - as field's value.

It seems like that checkbox was added with this PR as well?

That checkbox was proposed by spalger early on the PR. But I think the logic was changed over time, given the series of commits.