Skip to content

Instantly share code, notes, and snippets.

@scott-lydon

scott-lydon/PullRequestChecklist.md

Created November 22, 2022 22:49
Show Gist options
  • Save scott-lydon/b1498f865af1e5e28a9d15aec3eb93ed to your computer and use it in GitHub Desktop.
Save scott-lydon/b1498f865af1e5e28a9d15aec3eb93ed to your computer and use it in GitHub Desktop.
Download ZIP
A checklist for pull requests. It is added to as I get feedback for prs.
Raw
PullRequestChecklist.md
  • Its better to use existing functions than to create your own
  • Its better to add functionality to existing types than to create new types.
  • Remove unused code.
  • Give ui tests a timeout, longer for ci
  • following conventions for teams.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment