Skip to content

@scottwater /deprecated.rb
Created

Embed URL

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Is this the best pattern for deprecating a method paramater?
module FullContact
class Client
module Person
# Returns extended information for a given person (email, phone, twitter or facebook)
#
def person(options={})
if options.is_a?(String)
warn "[DEPRECATION] supplying an email address directly is deprecated. Please use {email: #{options}} instead."
options = {:email => options}
end
response = get('person', options)
format.to_s.downcase == 'xml' ? response['person'] : response
end
end
end
end
@scottwater
Owner

I should have pointed out the method initially looked like this:

def person(email)
response = get('person', email: email)
#....
end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.