Last active
February 20, 2017 11:12
-
-
Save senid231/dd6a13fd968a5cc926578deb65199ef7 to your computer and use it in GitHub Desktop.
json-api-resources bug with polymorphic relationship when primary_key is changed on resource level
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begin | |
require 'bundler/inline' | |
rescue LoadError => e | |
STDERR.puts 'Bundler version 1.10 or later is required. Please update your Bundler' | |
raise e | |
end | |
gemfile(true) do | |
source 'https://rubygems.org' | |
gem 'rails', '4.2.7', require: false | |
gem 'sqlite3', platform: :mri | |
gem 'activerecord-jdbcsqlite3-adapter', platform: :jruby | |
# gem 'jsonapi-resources', '0.8.0', require: false | |
# gem 'jsonapi-resources', require: false | |
gem 'jsonapi-resources', git: 'https://github.com/cerebris/jsonapi-resources', require: false | |
end | |
# prepare active_record database | |
require 'active_record' | |
ActiveRecord::Base.establish_connection(adapter: 'sqlite3', database: ':memory:') | |
ActiveRecord::Base.logger = Logger.new(STDOUT) | |
ActiveRecord::Schema.define do | |
# Add your schema here | |
create_table :storages, force: true do |t| | |
t.string :token, null: false | |
t.string :name | |
t.timestamps null: false | |
end | |
create_table :keepers, force: true do |t| | |
t.string :name | |
t.string :keepable_type, null: false | |
t.integer :keepable_id, null: false | |
t.timestamps null: false | |
end | |
end | |
# create models | |
class Storage < ActiveRecord::Base | |
has_one :keeper, class_name: 'Keeper', as: :keepable | |
end | |
class Keeper < ActiveRecord::Base | |
belongs_to :keepable, polymorphic: true | |
end | |
# prepare rails app | |
require 'action_controller/railtie' | |
# require 'action_view/railtie' | |
require 'jsonapi-resources' | |
class ApplicationController < ActionController::Base | |
end | |
# prepare jsonapi resources and controllers | |
class JsonApiController < ApplicationController | |
include JSONAPI::ActsAsResourceController | |
end | |
class StoragesController < JsonApiController | |
end | |
class KeepersController < JsonApiController | |
end | |
class StorageResource < JSONAPI::Resource | |
model_name 'Storage' | |
key_type :string | |
primary_key :token | |
attribute :name | |
end | |
class KeeperResource < JSONAPI::Resource | |
model_name 'Keeper' | |
has_one :keepable, polymorphic: true | |
attribute :name | |
end | |
class KeepableResource < JSONAPI::Resource | |
end | |
class TestApp < Rails::Application | |
config.root = File.dirname(__FILE__) | |
config.logger = Logger.new(STDOUT) | |
Rails.logger = config.logger | |
secrets.secret_token = 'secret_token' | |
secrets.secret_key_base = 'secret_key_base' | |
config.eager_load = false | |
end | |
# initialize app | |
Rails.application.initialize! | |
JSONAPI.configure do |config| | |
config.json_key_format = :underscored_key | |
config.route_format = :underscored_key | |
end | |
# draw routes | |
Rails.application.routes.draw do | |
jsonapi_resources :keepers, only: [:show] | |
end | |
# prepare tests | |
require 'minitest/autorun' | |
require 'rack/test' | |
# Replace this with the code necessary to make your test fail. | |
class BugTest < Minitest::Test | |
include Rack::Test::Methods | |
def response_json | |
JSON.parse(last_response.body) rescue nil | |
end | |
def pretty_response_json | |
JSON.pretty_generate(response_json) rescue nil | |
end | |
def json_api_headers | |
{'Accept' => JSONAPI::MEDIA_TYPE, 'CONTENT_TYPE' => JSONAPI::MEDIA_TYPE} | |
end | |
def test_show_keeper_include_keepable | |
storage = Storage.create! name: 'Warehouse 1', token: 'some-token' | |
keeper = Keeper.create! name: 'John Doe', keepable: storage | |
get "/keepers/#{keeper.id}", {include: 'keepable'}, json_api_headers | |
puts pretty_response_json | |
assert last_response.ok? | |
data = response_json['data'] | |
refute_nil data | |
assert_equal keeper.id.to_s, data['id'] | |
refute_nil data['relationships'] | |
refute_nil data['relationships']['keepable'] | |
refute_nil data['relationships']['keepable']['data'] | |
assert_equal 'storages', data['relationships']['keepable']['data']['type'] | |
assert_equal storage.token, data['relationships']['keepable']['data']['id'] | |
included = response_json['included'] | |
refute_nil included | |
assert_equal 'storages', included.first['type'] | |
assert_equal storage.token, included.first['id'] | |
end | |
private | |
def app | |
Rails.application | |
end | |
end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment