"リファクタリングのポイント" のサンプルコード (Replace Temp with Query)

package_composing_methods.replace_temp_with_query.after.java

package composing_methods.replace_temp_with_query.after;

public class Example {

    private int quantity;
    private int itemPrice;

    public double getPrice() {

        return basePrice() * discountFactor();
    }

    private double discountFactor() {

        if(basePrice() > 1000) {
            return = 0.95;
        } else {
            return = 0.98;
        }
    }

    private int basePrice() {
        return quantity * itemPrice;
    }
}

package_composing_methods.replace_temp_with_query.before.java

package composing_methods.replace_temp_with_query.after;

public class Example {

    private int quantity;
    private int itemPrice;

    public double getPrice() {

        int basePrice = quantity * itemPrice;
        double discountFactor;

        if(basePrice > 1000) {
            discountFactor = 0.95;
        } else {
            discountFactor = 0.98;
        }

        return basePrice * discountFactor;
    }
}

package_composing_methods.replace_temp_with_query.wip.java

package composing_methods.replace_temp_with_query.after;

public class Example {

    private int quantity;
    private int itemPrice;

    public double getPrice() {

        return basePrice() * discountFactor();
    }

    private double discountFactor() {

        if(basePrice() > 1000) {
            return = 0.95;
        } else {
            return = 0.98;
        }
    }
    
    private int basePrice() {
        return quantity * itemPrice;
    }
}