Skip to content

Instantly share code, notes, and snippets.

@sfsekaran
Last active August 24, 2018 17:34
Show Gist options
  • Save sfsekaran/89b8b6a9a717ba41cfd3f9e9865aac22 to your computer and use it in GitHub Desktop.
Save sfsekaran/89b8b6a9a717ba41cfd3f9e9865aac22 to your computer and use it in GitHub Desktop.
A Pull Request Checklist. Don't forget the basics!
Pull Request Checklist
- [ ] Does not require additional reviewers: specialized expertise
- [ ] Check for logic errors
- [ ] Check for missing, broken, wrong tests
- [ ] Check if looked for missing indexes
- [ ] Check for database transactional consistency issues
- [ ] Check all log levels are correct
- [ ] Check level of log detail
- [ ] Check code organization
- [ ] Check for confusing varible/function/class names
- [ ] Find code smells
- [ ] Check if needs updated documentation or README
- [ ] Check if has sufficient error reporting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment