Skip to content

Instantly share code, notes, and snippets.

@sgraham
Created September 20, 2019 19:59
Show Gist options
  • Save sgraham/412f186ab8d4854388d2cd8ba96e6f9c to your computer and use it in GitHub Desktop.
Save sgraham/412f186ab8d4854388d2cd8ba96e6f9c to your computer and use it in GitHub Desktop.
zircon/system/fidl/fuchsia-tee/tee.fidl:100:41: warning: parameters must be named in lower_snake_case [invalid-case-for-decl-member]; change 'OpResult' to 'op_result'
Proposed replacement: 'op_result'
-> (uint32 session_id, OpResult OpResult);
^~~~~~~~
zircon/system/fidl/fuchsia-tee/tee.fidl:105:22: warning: parameters must be named in lower_snake_case [invalid-case-for-decl-member]; change 'OpResult' to 'op_result'
Proposed replacement: 'op_result'
-> (OpResult OpResult);
^~~~~~~~
zircon/system/fidl/fuchsia-hardware-display/display-controller.fidl:11:14: warning: constants must be named in ALL_CAPS_SNAKE_CASE [invalid-case-for-constant]; change 'invalidId' to 'INVALID_ID'
Proposed replacement: 'INVALID_ID'
const uint64 invalidId = 0;
^~~~~~~~~
zircon/system/fidl/fuchsia-hardware-display/display-controller.fidl:34:13: warning: constants must be named in ALL_CAPS_SNAKE_CASE [invalid-case-for-constant]; change 'modeInterlaced' to 'MODE_INTERLACED'
Proposed replacement: 'MODE_INTERLACED'
const int32 modeInterlaced = 0x1;
^~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-hardware-display/display-controller.fidl:45:14: warning: constants must be named in ALL_CAPS_SNAKE_CASE [invalid-case-for-constant]; change 'identifierMaxLen' to 'IDENTIFIER_MAX_LEN'
Proposed replacement: 'IDENTIFIER_MAX_LEN'
const uint32 identifierMaxLen = 128;
^~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-hardware-display/display-controller.fidl:53:5: warning: Specify bounds for vector [vector-bounds-not-specified]
vector<Mode> modes;
^~~~~~
zircon/system/fidl/fuchsia-hardware-display/display-controller.fidl:56:5: warning: Specify bounds for vector [vector-bounds-not-specified]
vector<uint32> pixel_format;
^~~~~~
zircon/system/fidl/fuchsia-hardware-display/display-controller.fidl:64:5: warning: Specify bounds for vector [vector-bounds-not-specified]
vector<CursorInfo> cursor_configs;
^~~~~~
zircon/system/fidl/fuchsia-hardware-display/display-controller.fidl:94:14: warning: constants must be named in ALL_CAPS_SNAKE_CASE [invalid-case-for-constant]; change 'typeSimple' to 'TYPE_SIMPLE'
Proposed replacement: 'TYPE_SIMPLE'
const uint32 typeSimple = 0;
^~~~~~~~~~
zircon/system/fidl/fuchsia-hardware-display/display-controller.fidl:224:8: warning: Event names must start with 'On' [event-names-must-start-with-on]; change 'DisplaysChanged' to 'OnDisplaysChanged'
Proposed replacement: 'OnDisplaysChanged'
-> DisplaysChanged(vector<Info> added, vector<uint64> removed);
^~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-hardware-display/display-controller.fidl:224:24: warning: Specify bounds for vector [vector-bounds-not-specified]
-> DisplaysChanged(vector<Info> added, vector<uint64> removed);
^~~~~~
zircon/system/fidl/fuchsia-hardware-display/display-controller.fidl:224:44: warning: Specify bounds for vector [vector-bounds-not-specified]
-> DisplaysChanged(vector<Info> added, vector<uint64> removed);
^~~~~~
zircon/system/fidl/fuchsia-hardware-display/display-controller.fidl:304:41: warning: Specify bounds for vector [vector-bounds-not-specified]
SetDisplayLayers(uint64 display_id, vector<uint64> layer_ids);
^~~~~~
zircon/system/fidl/fuchsia-hardware-display/display-controller.fidl:367:63: warning: Specify bounds for vector [vector-bounds-not-specified]
SetLayerColorConfig(uint64 layer_id, uint32 pixel_format, vector<uint8> color_bytes);
^~~~~~
zircon/system/fidl/fuchsia-hardware-display/display-controller.fidl:415:53: warning: Specify bounds for vector [vector-bounds-not-specified]
CheckConfig(bool discard) -> (ConfigResult res, vector<ClientCompositionOp> ops);
^~~~~~
zircon/system/fidl/fuchsia-hardware-display/display-controller.fidl:434:8: warning: Event names must start with 'On' [event-names-must-start-with-on]; change 'Vsync' to 'OnVsync'
Proposed replacement: 'OnVsync'
-> Vsync(uint64 display_id, uint64 timestamp, vector<uint64> images);
^~~~~
zircon/system/fidl/fuchsia-hardware-display/display-controller.fidl:434:51: warning: Specify bounds for vector [vector-bounds-not-specified]
-> Vsync(uint64 display_id, uint64 timestamp, vector<uint64> images);
^~~~~~
zircon/system/fidl/fuchsia-hardware-display/display-controller.fidl:444:8: warning: Event names must start with 'On' [event-names-must-start-with-on]; change 'ClientOwnershipChange' to 'OnClientOwnershipChange'
Proposed replacement: 'OnClientOwnershipChange'
-> ClientOwnershipChange(bool has_ownership);
^~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-cobalt/cobalt.fidl:425:5: warning: Specify bounds for string [string-bounds-not-specified]
string dimension_name;
^~~~~~
zircon/system/fidl/fuchsia-cobalt/cobalt.fidl:433:5: warning: Specify bounds for string [string-bounds-not-specified]
string string_value;
^~~~~~
zircon/system/fidl/fuchsia-cobalt/cobalt.fidl:485:5: warning: Specify bounds for vector [vector-bounds-not-specified]
vector<HistogramBucket> int_histogram;
^~~~~~
zircon/system/fidl/fuchsia-cobalt/cobalt.fidl:547:42: warning: Specify bounds for vector [vector-bounds-not-specified]
string:64 component, vector<HistogramBucket> histogram)
^~~~~~
zircon/system/fidl/fuchsia-cobalt/cobalt.fidl:560:38: warning: Specify bounds for vector [vector-bounds-not-specified]
LogCustomEvent(uint32 metric_id, vector<CustomEventValue> event_values)
^~~~~~
zircon/system/fidl/fuchsia-cobalt/cobalt.fidl:573:21: warning: Specify bounds for vector [vector-bounds-not-specified]
LogCobaltEvents(vector<CobaltEvent> events) -> (Status status);
^~~~~~
zircon/system/fidl/fuchsia-cobalt/cobalt.fidl:629:24: warning: Specify bounds for vector [vector-bounds-not-specified]
SetExperimentState(vector<Experiment> experiments)
^~~~~~
zircon/system/fidl/fuchsia-cobalt/cobalt.fidl:636:16: warning: Specify bounds for string [string-bounds-not-specified]
SetChannel(string current_channel) -> (Status status);
^~~~~~
zircon/system/fidl/fuchsia-cobalt/cobalt_controller.fidl:52:54: warning: Specify bounds for vector [vector-bounds-not-specified]
GenerateAggregatedObservations(uint32 day_index, vector<uint32> report_ids)
^~~~~~
zircon/system/fidl/fuchsia-cobalt/cobalt_controller.fidl:53:9: warning: Specify bounds for vector [vector-bounds-not-specified]
-> (vector<uint64> num_obs);
^~~~~~
zircon/system/fidl/fuchsia-hardware-usb-tester/usb-tester.fidl:5:9: warning: Avoid library names with more than two dots [too-many-nested-libraries]
library fuchsia.hardware.usb.tester;
^~~~~~~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-hardware-block-volume/volume.fidl:5:9: warning: Avoid library names with more than two dots [too-many-nested-libraries]
library fuchsia.hardware.block.volume;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-hardware-block-volume/volume.fidl:46:14: warning: constants must be named in ALL_CAPS_SNAKE_CASE [invalid-case-for-constant]; change 'AllocatePartitionFlagInactive' to 'ALLOCATE_PARTITION_FLAG_INACTIVE'
Proposed replacement: 'ALLOCATE_PARTITION_FLAG_INACTIVE'
const uint32 AllocatePartitionFlagInactive = 0x00000001;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-hardware-ramdisk/ramdisk.fidl:57:8: warning: structs must be named in UpperCamelCase [invalid-case-for-decl-name]; change 'GUID' to 'Guid'
Proposed replacement: 'Guid'
struct GUID {
^~~~
zircon/system/fidl/fuchsia-net-stack/stack.fidl:39:27: warning: struct members must be named in lower_snake_case [invalid-case-for-decl-member]; change 'ipAddress' to 'ip_address'
Proposed replacement: 'ip_address'
fuchsia.net.IpAddress ipAddress;
^~~~~~~~~
zircon/system/fidl/fuchsia-net-stack/stack.fidl:42:11: warning: struct members must be named in lower_snake_case [invalid-case-for-decl-member]; change 'prefixLen' to 'prefix_len'
Proposed replacement: 'prefix_len'
uint8 prefixLen;
^~~~~~~~~
zircon/system/fidl/fuchsia-net-stack/stack.fidl:57:5: warning: Specify bounds for string [string-bounds-not-specified]
string name;
^~~~~~
zircon/system/fidl/fuchsia-net-stack/stack.fidl:61:5: warning: Specify bounds for string [string-bounds-not-specified]
string topopath;
^~~~~~
zircon/system/fidl/fuchsia-net-stack/stack.fidl:65:5: warning: Specify bounds for string [string-bounds-not-specified]
string filepath;
^~~~~~
zircon/system/fidl/fuchsia-net-stack/stack.fidl:78:26: warning: struct members must be named in lower_snake_case [invalid-case-for-decl-member]; change 'administrativeStatus' to 'administrative_status'
Proposed replacement: 'administrative_status'
AdministrativeStatus administrativeStatus;
^~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-net-stack/stack.fidl:81:20: warning: struct members must be named in lower_snake_case [invalid-case-for-decl-member]; change 'physicalStatus' to 'physical_status'
Proposed replacement: 'physical_status'
PhysicalStatus physicalStatus;
^~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-net-stack/stack.fidl:84:5: warning: Specify bounds for vector [vector-bounds-not-specified]
vector<InterfaceAddress> addresses;
^~~~~~
zircon/system/fidl/fuchsia-net-stack/stack.fidl:91:12: warning: union members must be named in lower_snake_case [invalid-case-for-decl-member]; change 'deviceId' to 'device_id'
Proposed replacement: 'device_id'
uint64 deviceId;
^~~~~~~~
zircon/system/fidl/fuchsia-net-stack/stack.fidl:94:27: warning: union members must be named in lower_snake_case [invalid-case-for-decl-member]; change 'nextHop' to 'next_hop'
Proposed replacement: 'next_hop'
fuchsia.net.IpAddress nextHop;
^~~~~~~
zircon/system/fidl/fuchsia-net-stack/stack.fidl:129:26: warning: Specify bounds for string [string-bounds-not-specified]
AddEthernetInterface(string topological_path, fuchsia.hardware.ethernet.Device device) -> (uint64 id) error Error;
^~~~~~
zircon/system/fidl/fuchsia-net-stack/stack.fidl:135:26: warning: Specify bounds for vector [vector-bounds-not-specified]
ListInterfaces() -> (vector<InterfaceInfo> ifs);
^~~~~~
zircon/system/fidl/fuchsia-net-stack/stack.fidl:155:30: warning: Specify bounds for vector [vector-bounds-not-specified]
GetForwardingTable() -> (vector<ForwardingEntry> table);
^~~~~~
zircon/system/fidl/fuchsia-hardware-goldfish-control/goldfish-control.fidl:5:9: warning: Avoid library names with more than two dots [too-many-nested-libraries]
library fuchsia.hardware.goldfish.control;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-posix-socket/socket.fidl:22:10: warning: Specify bounds for vector [vector-bounds-not-specified]
Bind(vector<uint8> addr) -> (int16 code);
^~~~~~
zircon/system/fidl/fuchsia-posix-socket/socket.fidl:24:13: warning: Specify bounds for vector [vector-bounds-not-specified]
Connect(vector<uint8> addr) -> (int16 code);
^~~~~~
zircon/system/fidl/fuchsia-posix-socket/socket.fidl:31:35: warning: Specify bounds for vector [vector-bounds-not-specified]
GetSockName() -> (int16 code, vector<uint8> addr);
^~~~~~
zircon/system/fidl/fuchsia-posix-socket/socket.fidl:33:35: warning: Specify bounds for vector [vector-bounds-not-specified]
GetPeerName() -> (int16 code, vector<uint8> addr);
^~~~~~
zircon/system/fidl/fuchsia-posix-socket/socket.fidl:35:44: warning: Specify bounds for vector [vector-bounds-not-specified]
SetSockOpt(int16 level, int16 optname, vector<uint8> optval) -> (int16 code);
^~~~~~
zircon/system/fidl/fuchsia-posix-socket/socket.fidl:38:60: warning: Specify bounds for vector [vector-bounds-not-specified]
GetSockOpt(int16 level, int16 optname) -> (int16 code, vector<uint8> optval);
^~~~~~
zircon/system/fidl/fuchsia-posix-socket/socket.fidl:41:5: warning: methods must be named in UpperCamelCase [invalid-case-for-decl-name]; change 'IoctlPOSIX' to 'IoctlPosix'
Proposed replacement: 'IoctlPosix'
IoctlPOSIX(int16 req, vector<uint8> in) -> (int16 code, vector<uint8> out);
^~~~~~~~~~
zircon/system/fidl/fuchsia-posix-socket/socket.fidl:41:27: warning: Specify bounds for vector [vector-bounds-not-specified]
IoctlPOSIX(int16 req, vector<uint8> in) -> (int16 code, vector<uint8> out);
^~~~~~
zircon/system/fidl/fuchsia-posix-socket/socket.fidl:41:61: warning: Specify bounds for vector [vector-bounds-not-specified]
IoctlPOSIX(int16 req, vector<uint8> in) -> (int16 code, vector<uint8> out);
^~~~~~
zircon/system/fidl/fuchsia-hardware-block-partition/partition.fidl:5:9: warning: Avoid library names with more than two dots [too-many-nested-libraries]
library fuchsia.hardware.block.partition;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-hardware-block-partition/partition.fidl:14:8: warning: structs must be named in UpperCamelCase [invalid-case-for-decl-name]; change 'GUID' to 'Guid'
Proposed replacement: 'Guid'
struct GUID {
^~~~
zircon/system/fidl/fuchsia-hardware-cpu-insntrace/insntrace.fidl:5:9: warning: Avoid library names with more than two dots [too-many-nested-libraries]
library fuchsia.hardware.cpu.insntrace;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-hardware-goldfish-address-space/goldfish-address-space.fidl:5:9: warning: Avoid library names with more than two dots [too-many-nested-libraries]
library fuchsia.hardware.goldfish.address.space;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-process/launcher.fidl:58:5: warning: Specify bounds for string [string-bounds-not-specified]
string name;
^~~~~~
zircon/system/fidl/fuchsia-process/launcher.fidl:142:13: warning: Specify bounds for vector [vector-bounds-not-specified]
AddArgs(vector<vector<uint8>> args);
^~~~~~
zircon/system/fidl/fuchsia-process/launcher.fidl:142:20: warning: Specify bounds for vector [vector-bounds-not-specified]
AddArgs(vector<vector<uint8>> args);
^~~~~~
zircon/system/fidl/fuchsia-process/launcher.fidl:147:17: warning: Specify bounds for vector [vector-bounds-not-specified]
AddEnvirons(vector<vector<uint8>> environ);
^~~~~~
zircon/system/fidl/fuchsia-process/launcher.fidl:147:24: warning: Specify bounds for vector [vector-bounds-not-specified]
AddEnvirons(vector<vector<uint8>> environ);
^~~~~~
zircon/system/fidl/fuchsia-process/launcher.fidl:156:14: warning: Specify bounds for vector [vector-bounds-not-specified]
AddNames(vector<NameInfo> names);
^~~~~~
zircon/system/fidl/fuchsia-process/launcher.fidl:161:16: warning: Specify bounds for vector [vector-bounds-not-specified]
AddHandles(vector<HandleInfo> handles);
^~~~~~
zircon/system/fidl/fuchsia-hardware-usb-fwloader/usb-fwloader.fidl:5:9: warning: Avoid library names with more than two dots [too-many-nested-libraries]
library fuchsia.hardware.usb.fwloader;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-kernel/kernel-stats.fidl:48:3: warning: Specify bounds for vector [vector-bounds-not-specified]
vector<PerCpuStats>? per_cpu_stats;
^~~~~~
zircon/system/fidl/fuchsia-hardware-usb-peripheral-block/usb-peripheral-block.fidl:5:9: warning: Avoid library names with more than two dots [too-many-nested-libraries]
library fuchsia.hardware.usb.peripheral.block;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-exception/process_limbo.fidl:2:74: warning: FIDL files defined in the Platform Source Tree (i.e., defined in fuchsia.googlesource.com) must begin with the standard copyright notice [invalid-copyright-for-platform-source-library]; Update your header with:
// Copyright 2019 The Fuchsia Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Use of this source code is governed by a BSD-style license that can be found in the LICENSE file.
^~~~~~~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-exception/process_limbo.fidl:12:42: warning: Specify bounds for vector [vector-bounds-not-specified]
GetProcessesWaitingOnException() -> (vector<ProcessException> process_exceptions);
^~~~~~
zircon/system/fidl/fuchsia-exception/handler.fidl:2:74: warning: FIDL files defined in the Platform Source Tree (i.e., defined in fuchsia.googlesource.com) must begin with the standard copyright notice [invalid-copyright-for-platform-source-library]; Update your header with:
// Copyright 2019 The Fuchsia Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// Use of this source code is governed by a BSD-style license that can be found in the LICENSE file.
^~~~~~~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-hardware-usb-device/usb-device.fidl:5:9: warning: Avoid library names with more than two dots [too-many-nested-libraries]
library fuchsia.hardware.usb.device;
^~~~~~~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-sysmem/usages.fidl:21:14: warning: constants must be named in ALL_CAPS_SNAKE_CASE [invalid-case-for-constant]; change 'noneUsage' to 'NONE_USAGE'
Proposed replacement: 'NONE_USAGE'
const uint32 noneUsage = 1;
^~~~~~~~~
zircon/system/fidl/fuchsia-sysmem/usages.fidl:25:14: warning: constants must be named in ALL_CAPS_SNAKE_CASE [invalid-case-for-constant]; change 'cpuUsageRead' to 'CPU_USAGE_READ'
Proposed replacement: 'CPU_USAGE_READ'
const uint32 cpuUsageRead = 1;
^~~~~~~~~~~~
zircon/system/fidl/fuchsia-sysmem/usages.fidl:26:14: warning: constants must be named in ALL_CAPS_SNAKE_CASE [invalid-case-for-constant]; change 'cpuUsageReadOften' to 'CPU_USAGE_READ_OFTEN'
Proposed replacement: 'CPU_USAGE_READ_OFTEN'
const uint32 cpuUsageReadOften = 2;
^~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-sysmem/usages.fidl:27:14: warning: constants must be named in ALL_CAPS_SNAKE_CASE [invalid-case-for-constant]; change 'cpuUsageWrite' to 'CPU_USAGE_WRITE'
Proposed replacement: 'CPU_USAGE_WRITE'
const uint32 cpuUsageWrite = 4;
^~~~~~~~~~~~~
zircon/system/fidl/fuchsia-sysmem/usages.fidl:28:14: warning: constants must be named in ALL_CAPS_SNAKE_CASE [invalid-case-for-constant]; change 'cpuUsageWriteOften' to 'CPU_USAGE_WRITE_OFTEN'
Proposed replacement: 'CPU_USAGE_WRITE_OFTEN'
const uint32 cpuUsageWriteOften = 8;
^~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-sysmem/usages.fidl:32:14: warning: constants must be named in ALL_CAPS_SNAKE_CASE [invalid-case-for-constant]; change 'vulkanUsageTransferSrc' to 'VULKAN_USAGE_TRANSFER_SRC'
Proposed replacement: 'VULKAN_USAGE_TRANSFER_SRC'
const uint32 vulkanUsageTransferSrc = 0x0001;
^~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-sysmem/usages.fidl:33:14: warning: constants must be named in ALL_CAPS_SNAKE_CASE [invalid-case-for-constant]; change 'vulkanUsageTransferDst' to 'VULKAN_USAGE_TRANSFER_DST'
Proposed replacement: 'VULKAN_USAGE_TRANSFER_DST'
const uint32 vulkanUsageTransferDst = 0x0002;
^~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-sysmem/usages.fidl:34:14: warning: constants must be named in ALL_CAPS_SNAKE_CASE [invalid-case-for-constant]; change 'vulkanUsageSampled' to 'VULKAN_USAGE_SAMPLED'
Proposed replacement: 'VULKAN_USAGE_SAMPLED'
const uint32 vulkanUsageSampled = 0x0004;
^~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-sysmem/usages.fidl:35:14: warning: constants must be named in ALL_CAPS_SNAKE_CASE [invalid-case-for-constant]; change 'vulkanUsageStorage' to 'VULKAN_USAGE_STORAGE'
Proposed replacement: 'VULKAN_USAGE_STORAGE'
const uint32 vulkanUsageStorage = 0x0008;
^~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-sysmem/usages.fidl:36:14: warning: constants must be named in ALL_CAPS_SNAKE_CASE [invalid-case-for-constant]; change 'vulkanUsageColorAttachment' to 'VULKAN_USAGE_COLOR_ATTACHMENT'
Proposed replacement: 'VULKAN_USAGE_COLOR_ATTACHMENT'
const uint32 vulkanUsageColorAttachment = 0x0010;
^~~~~~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-sysmem/usages.fidl:37:14: warning: constants must be named in ALL_CAPS_SNAKE_CASE [invalid-case-for-constant]; change 'vulkanUsageStencilAttachment' to 'VULKAN_USAGE_STENCIL_ATTACHMENT'
Proposed replacement: 'VULKAN_USAGE_STENCIL_ATTACHMENT'
const uint32 vulkanUsageStencilAttachment = 0x0020;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-sysmem/usages.fidl:38:14: warning: constants must be named in ALL_CAPS_SNAKE_CASE [invalid-case-for-constant]; change 'vulkanUsageTransientAttachment' to 'VULKAN_USAGE_TRANSIENT_ATTACHMENT'
Proposed replacement: 'VULKAN_USAGE_TRANSIENT_ATTACHMENT'
const uint32 vulkanUsageTransientAttachment = 0x0040;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-sysmem/usages.fidl:39:14: warning: constants must be named in ALL_CAPS_SNAKE_CASE [invalid-case-for-constant]; change 'vulkanUsageInputAttachment' to 'VULKAN_USAGE_INPUT_ATTACHMENT'
Proposed replacement: 'VULKAN_USAGE_INPUT_ATTACHMENT'
const uint32 vulkanUsageInputAttachment = 0x0080;
^~~~~~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-sysmem/usages.fidl:42:14: warning: constants must be named in ALL_CAPS_SNAKE_CASE [invalid-case-for-constant]; change 'displayUsageLayer' to 'DISPLAY_USAGE_LAYER'
Proposed replacement: 'DISPLAY_USAGE_LAYER'
const uint32 displayUsageLayer = 1;
^~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-sysmem/usages.fidl:43:14: warning: constants must be named in ALL_CAPS_SNAKE_CASE [invalid-case-for-constant]; change 'displayUsageCursor' to 'DISPLAY_USAGE_CURSOR'
Proposed replacement: 'DISPLAY_USAGE_CURSOR'
const uint32 displayUsageCursor = 2;
^~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-sysmem/usages.fidl:47:14: warning: constants must be named in ALL_CAPS_SNAKE_CASE [invalid-case-for-constant]; change 'videoUsageHwDecoder' to 'VIDEO_USAGE_HW_DECODER'
Proposed replacement: 'VIDEO_USAGE_HW_DECODER'
const uint32 videoUsageHwDecoder = 1;
^~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-sysmem/usages.fidl:48:14: warning: constants must be named in ALL_CAPS_SNAKE_CASE [invalid-case-for-constant]; change 'videoUsageHwEncoder' to 'VIDEO_USAGE_HW_ENCODER'
Proposed replacement: 'VIDEO_USAGE_HW_ENCODER'
const uint32 videoUsageHwEncoder = 2;
^~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-sysmem/usages.fidl:51:14: warning: constants must be named in ALL_CAPS_SNAKE_CASE [invalid-case-for-constant]; change 'videoUsageHwProtected' to 'VIDEO_USAGE_HW_PROTECTED'
Proposed replacement: 'VIDEO_USAGE_HW_PROTECTED'
const uint32 videoUsageHwProtected = 4;
^~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-sysmem/usages.fidl:52:14: warning: constants must be named in ALL_CAPS_SNAKE_CASE [invalid-case-for-constant]; change 'videoUsageCapture' to 'VIDEO_USAGE_CAPTURE'
Proposed replacement: 'VIDEO_USAGE_CAPTURE'
const uint32 videoUsageCapture = 8;
^~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-sysmem/format_modifier.fidl:56:14: warning: constants must be named in ALL_CAPS_SNAKE_CASE [invalid-case-for-constant]; change 'FORMAT_MODIFIER_ARM_AFBC_16x16' to 'FORMAT_MODIFIER_ARM_AFBC_16X16'
Proposed replacement: 'FORMAT_MODIFIER_ARM_AFBC_16X16'
const uint64 FORMAT_MODIFIER_ARM_AFBC_16x16 = 0x0800000000000001;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-sysmem/format_modifier.fidl:57:14: warning: constants must be named in ALL_CAPS_SNAKE_CASE [invalid-case-for-constant]; change 'FORMAT_MODIFIER_ARM_AFBC_32x8' to 'FORMAT_MODIFIER_ARM_AFBC_32X8'
Proposed replacement: 'FORMAT_MODIFIER_ARM_AFBC_32X8'
const uint64 FORMAT_MODIFIER_ARM_AFBC_32x8 = 0x0800000000000002;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-hardware-block/block.fidl:69:8: warning: structs must be named in UpperCamelCase [invalid-case-for-decl-name]; change 'VmoID' to 'VmoId'
Proposed replacement: 'VmoId'
struct VmoID {
^~~~~
zircon/system/fidl/fuchsia-logger/logger.fidl:41:12: warning: Specify bounds for string [string-bounds-not-specified]
vector<string>:MAX_TAGS tags;
^~~~~~
zircon/system/fidl/fuchsia-logger/logger.fidl:59:12: warning: Specify bounds for string [string-bounds-not-specified]
vector<string>:MAX_TAGS_PER_LOG_MESSAGE tags;
^~~~~~
zircon/system/fidl/fuchsia-logger/logger.fidl:60:5: warning: Specify bounds for string [string-bounds-not-specified]
string msg;
^~~~~~
zircon/system/fidl/fuchsia-logger/logger.fidl:91:13: warning: Specify bounds for vector [vector-bounds-not-specified]
LogMany(vector<LogMessage> log);
^~~~~~
zircon/system/fidl/fuchsia-hardware-goldfish-pipe/goldfish-pipe.fidl:5:9: warning: Avoid library names with more than two dots [too-many-nested-libraries]
library fuchsia.hardware.goldfish.pipe;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-metricbroker/broker.fidl:54:5: warning: Specify bounds for string [string-bounds-not-specified]
string? project_name;
^~~~~~
zircon/system/fidl/fuchsia-hardware-telephony-transport/qmi.fidl:5:9: warning: Avoid library names with more than two dots [too-many-nested-libraries]
library fuchsia.hardware.telephony.transport;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-tee-manager/provider.fidl:13:10: warning: Protocols must not include the name 'service.' [protocol-name-includes-service]
protocol ServiceProvider {
^~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-hardware-zxcrypt/devicemanager.fidl:5:26: warning: Library names must not contain the following components: common, service, util, base, f<letter>l, zx<word> [disallowed-library-name-component]
library fuchsia.hardware.zxcrypt;
^~~~~~~
zircon/system/fidl/fuchsia-device-manager/coordinator.fidl:254:24: warning: Specify bounds for vector [vector-bounds-not-specified]
vector<DeviceComponent> components, uint32 coresident_device_index) -> () error zx.status;
^~~~~~
zircon/system/fidl/fuchsia-device-manager/administrator.fidl:17:1: warning: TODO comment should use a non-flow-through comment marker [todo-should-not-be-doc-comment]; change '///' to '//'
Proposed replacement: '//'
/// TODO(ravoorir): When the system power states are properly defined,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-camera-common/common.fidl:9:24: warning: Library names must not contain the following components: common, service, util, base, f<letter>l, zx<word> [disallowed-library-name-component]
library fuchsia.camera.common;
^~~~~~
zircon/system/fidl/fuchsia-camera-common/virtual.fidl:7:24: warning: Library names must not contain the following components: common, service, util, base, f<letter>l, zx<word> [disallowed-library-name-component]
library fuchsia.camera.common;
^~~~~~
zircon/system/fidl/fuchsia-camera-common/virtual.fidl:34:3: warning: Specify bounds for vector [vector-bounds-not-specified]
vector<VideoFormat> formats;
^~~~~~
zircon/system/fidl/fuchsia-hardware-usb-virtual-bus/usb-virtual-bus.fidl:5:9: warning: Avoid library names with more than two dots [too-many-nested-libraries]
library fuchsia.hardware.usb.virtual.bus;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-hardware-usb-peripheral/usb-peripheral.fidl:5:9: warning: Avoid library names with more than two dots [too-many-nested-libraries]
library fuchsia.hardware.usb.peripheral;
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-hardware-usb-peripheral/usb-peripheral.fidl:23:12: warning: struct members must be named in lower_snake_case [invalid-case-for-decl-member]; change 'bcdUSB' to 'bcd_usb'
Proposed replacement: 'bcd_usb'
uint16 bcdUSB;
^~~~~~
zircon/system/fidl/fuchsia-hardware-usb-peripheral/usb-peripheral.fidl:24:11: warning: struct members must be named in lower_snake_case [invalid-case-for-decl-member]; change 'bDeviceClass' to 'b_device_class'
Proposed replacement: 'b_device_class'
uint8 bDeviceClass;
^~~~~~~~~~~~
zircon/system/fidl/fuchsia-hardware-usb-peripheral/usb-peripheral.fidl:25:11: warning: struct members must be named in lower_snake_case [invalid-case-for-decl-member]; change 'bDeviceSubClass' to 'b_device_sub_class'
Proposed replacement: 'b_device_sub_class'
uint8 bDeviceSubClass;
^~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-hardware-usb-peripheral/usb-peripheral.fidl:26:11: warning: struct members must be named in lower_snake_case [invalid-case-for-decl-member]; change 'bDeviceProtocol' to 'b_device_protocol'
Proposed replacement: 'b_device_protocol'
uint8 bDeviceProtocol;
^~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-hardware-usb-peripheral/usb-peripheral.fidl:27:11: warning: struct members must be named in lower_snake_case [invalid-case-for-decl-member]; change 'bMaxPacketSize0' to 'b_max_packet_size0'
Proposed replacement: 'b_max_packet_size0'
uint8 bMaxPacketSize0;
^~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-hardware-usb-peripheral/usb-peripheral.fidl:28:12: warning: struct members must be named in lower_snake_case [invalid-case-for-decl-member]; change 'idVendor' to 'id_vendor'
Proposed replacement: 'id_vendor'
uint16 idVendor;
^~~~~~~~
zircon/system/fidl/fuchsia-hardware-usb-peripheral/usb-peripheral.fidl:29:12: warning: struct members must be named in lower_snake_case [invalid-case-for-decl-member]; change 'idProduct' to 'id_product'
Proposed replacement: 'id_product'
uint16 idProduct;
^~~~~~~~~
zircon/system/fidl/fuchsia-hardware-usb-peripheral/usb-peripheral.fidl:30:12: warning: struct members must be named in lower_snake_case [invalid-case-for-decl-member]; change 'bcdDevice' to 'bcd_device'
Proposed replacement: 'bcd_device'
uint16 bcdDevice;
^~~~~~~~~
zircon/system/fidl/fuchsia-hardware-usb-peripheral/usb-peripheral.fidl:34:11: warning: struct members must be named in lower_snake_case [invalid-case-for-decl-member]; change 'bNumConfigurations' to 'b_num_configurations'
Proposed replacement: 'b_num_configurations'
uint8 bNumConfigurations;
^~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-hardware-gpu-clock/clock.fidl:5:9: warning: Avoid library names with more than two dots [too-many-nested-libraries]
library fuchsia.hardware.gpu.clock;
^~~~~~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-device-manager-test/metadata.fidl:5:9: warning: Avoid library names with more than two dots [too-many-nested-libraries]
library fuchsia.device.manager.test;
^~~~~~~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-device/name-provider.fidl:15:25: warning: Specify bounds for string [string-bounds-not-specified]
GetDeviceName() -> (string name) error zx.status;
^~~~~~
zircon/system/fidl/fuchsia-inspect/inspect.fidl:8:5: warning: Specify bounds for string [string-bounds-not-specified]
string str;
^~~~~~
zircon/system/fidl/fuchsia-inspect/inspect.fidl:9:5: warning: Specify bounds for vector [vector-bounds-not-specified]
vector<uint8> bytes;
^~~~~~
zircon/system/fidl/fuchsia-inspect/inspect.fidl:14:5: warning: Specify bounds for string [string-bounds-not-specified]
string key;
^~~~~~
zircon/system/fidl/fuchsia-inspect/inspect.fidl:27:5: warning: Specify bounds for string [string-bounds-not-specified]
string key;
^~~~~~
zircon/system/fidl/fuchsia-inspect/inspect.fidl:33:5: warning: Specify bounds for string [string-bounds-not-specified]
string name;
^~~~~~
zircon/system/fidl/fuchsia-inspect/inspect.fidl:34:5: warning: Specify bounds for vector [vector-bounds-not-specified]
vector<Property>? properties;
^~~~~~
zircon/system/fidl/fuchsia-inspect/inspect.fidl:35:5: warning: Specify bounds for vector [vector-bounds-not-specified]
vector<Metric>? metrics;
^~~~~~
zircon/system/fidl/fuchsia-inspect/inspect.fidl:43:24: warning: Specify bounds for vector [vector-bounds-not-specified]
ListChildren() -> (vector<string>? children_names);
^~~~~~
zircon/system/fidl/fuchsia-inspect/inspect.fidl:43:31: warning: Specify bounds for string [string-bounds-not-specified]
ListChildren() -> (vector<string>? children_names);
^~~~~~
zircon/system/fidl/fuchsia-inspect/inspect.fidl:46:15: warning: Specify bounds for string [string-bounds-not-specified]
OpenChild(string child_name, request<Inspect> child_channel) -> (bool success);
^~~~~~
zircon/system/fidl/fuchsia-hardware-intel-hda/codec.fidl:5:9: warning: Avoid library names with more than two dots [too-many-nested-libraries]
library fuchsia.hardware.intel.hda;
^~~~~~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-hardware-intel-hda/controller.fidl:5:9: warning: Avoid library names with more than two dots [too-many-nested-libraries]
library fuchsia.hardware.intel.hda;
^~~~~~~~~~~~~~~~~~~~~~~~~~
zircon/system/fidl/fuchsia-net/namelookup.fidl:9:5: warning: Specify bounds for vector [vector-bounds-not-specified]
vector<Ipv4Address> ipv4_addrs;
^~~~~~
zircon/system/fidl/fuchsia-net/namelookup.fidl:11:5: warning: Specify bounds for vector [vector-bounds-not-specified]
vector<Ipv6Address> ipv6_addrs;
^~~~~~
zircon/system/fidl/fuchsia-net/namelookup.fidl:13:5: warning: Specify bounds for string [string-bounds-not-specified]
string? canonical_name;
^~~~~~
zircon/system/fidl/fuchsia-hardware-ethernet/ethernet.fidl:80:5: warning: methods must be named in UpperCamelCase [invalid-case-for-decl-name]; change 'SetIOBuffer' to 'SetIoBuffer'
Proposed replacement: 'SetIoBuffer'
SetIOBuffer(handle<vmo> h) -> (zx.status status);
^~~~~~~~~~~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment